Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix material-ui warnings due to wrong styles in theme #124

Merged
merged 2 commits into from
Mar 17, 2021
Merged

Fix material-ui warnings due to wrong styles in theme #124

merged 2 commits into from
Mar 17, 2021

Conversation

padawannn
Copy link
Contributor

@padawannn padawannn commented Mar 17, 2021 •
edited

@shortcut-integration
Copy link

This pull request has been linked to Clubhouse Story #141321: Material UI / Redux warnings in template proj.

@coveralls
Copy link
Collaborator

coveralls commented Mar 17, 2021 •
edited

Pull Request Test Coverage Report for Build 661960224

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 79.255%
Totals Coverage Status
Change from base Build 658953656: 0.0%
Covered Lines: 583
Relevant Lines: 698
💛 - Coveralls

VictorVelarde
VictorVelarde approved these changes Mar 17, 2021
View reviewed changes
Copy link
Contributor

@VictorVelarde VictorVelarde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, please add a clear note to changelog (unreleased), like "Fix material-ui warnings due to wrong styles in theme" and merge it

@VictorVelarde VictorVelarde changed the title resolve warnings Fix material-ui warnings due to wrong styles in theme Mar 17, 2021
@padawannn padawannn merged commit a2c25c3 into master Mar 17, 2021
@padawannn padawannn deleted the feature/ch141321/material-ui-redux-warnings-in-template-proj branch March 17, 2021 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VictorVelarde VictorVelarde VictorVelarde approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@padawannn @coveralls @VictorVelarde