Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some fixes around localization #1664

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Some fixes around localization #1664

wants to merge 2 commits into from

Conversation

levinli303
Copy link
Collaborator

levinli303
levinli303 commented Mar 30, 2023
View reviewed changes
src/celestia/qt/qtappwin.cpp
@@ -227,6 +227,14 @@ void CelestiaAppWindow::init(const CelestiaCommandLineOptions& options)
exit(1);
}

#ifdef ENABLE_NLS
bindtextdomain("celestia", "locale");
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure what else we coould be passing here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't think that the main file should be rebound. only celestia-data should be.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And only if translations exist there.

@sonarcloud
Copy link

sonarcloud bot commented Mar 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@levinli303 levinli303 marked this pull request as draft April 1, 2023 10:05
@375gnu 375gnu force-pushed the master branch 2 times, most recently from 690ab56 to 2f8f3b0 Compare May 15, 2023 19:57
@375gnu 375gnu changed the title Some fixed around localization Some fixes around localization Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@375gnu 375gnu 375gnu left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@levinli303 @375gnu