[ENG-2814][ENG-4816] Allow Read-only and Read/Write contributors to view a project's draft registrations #10468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Johnetordoff
force-pushed
the
draft-registration-permissions
branch
17 times, most recently
from
bed1532
to
307b1b9
Compare
Johnetordoff
changed the title
Johnetordoff
force-pushed
the
draft-registration-permissions
branch
3 times, most recently
from
2607084
to
5b4f69a
Compare
Johnetordoff
commented
Oct 23, 2023
| @@ -548,9 +564,8 @@ def test_write_contributor_can_update_draft( | |||
| assert data['attributes']['registration_metadata'] == payload['data']['attributes']['registration_metadata'] | |||
|
|
|||
|
|
|||
| class TestDraftRegistrationDelete(TestDraftRegistrationDelete): | |||
There was a problem hiding this comment.
Just changing this name to not mirror the superclass
Johnetordoff
force-pushed
the
draft-registration-permissions
branch
4 times, most recently
from
2703b3f
to
81420b7
Compare
Johnetordoff
force-pushed
the
draft-registration-permissions
branch
from
81420b7
to
b91536e
Compare
Johnetordoff
force-pushed
the
draft-registration-permissions
branch
from
b4eb14e
to
1ae8f29
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Change permissions for DraftRegistrations so Read/Write contributors can view all listed DraftRegistrations for a node.
GET for reading, POST for DR creation and PATCH for editing
Changes
NodeDraftRegistrationsListPermissiontoNodeDraftRegistrationsListtest_<user_permission>_draft_not_nodehas all casesQA Notes
old test structure:
new flat structure
DraftRegistrationTestCaseis refactored asAbstractDraftRegistrationTestCase:What are the areas of risk?
Any concerns/considerations/questions that development raised?
Documentation
Side Effects
Because this dealt this tests that covered two permissions cases that acted differently I decided to split-up and partially re-write these tests.
Ticket
https://openscience.atlassian.net/browse/ENG-2814
https://openscience.atlassian.net/browse/ENG-4816