Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENG-4961] Allow s3 full configuration via V2 API #10493

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Johnetordoff
Copy link
Contributor

@Johnetordoff Johnetordoff commented Nov 28, 2023

Purpose

S3 should now support “Write-only” fields for s3 specific credentials. This will allow users to configure S3 addons fully through the v2 API.

Changes

  • adds new custom serializer that allows s3 authorization.
  • adds tests

QA Notes

Expected payloads for:
Credentials

{ 'data': {'attributes': {'access_token': 'test_access_key', 'secret_token': 'test_secret_key'}}}

Folders

{'data': {'attributes': {'folder_id': 'test_folder_id', 'folder_path': 'test_folder_path:/'}}}

For "pre-configuration" info, like bucket and subfolder names use the /v2/nodes/{node._id}/addons/s3/folders/ endpoint

Documentation

Information about setting the site up locally can be found here at addons/s3/README.md.

Side Effects

Ticket

https://openscience.atlassian.net/browse/ENG-4961

@Johnetordoff Johnetordoff force-pushed the v2-config-s3 branch 2 times, most recently from 456c6de to c9cb810 Compare December 1, 2023 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant