Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add CedarMetadataRecord.clean #10525

Open
wants to merge 1 commit into
base: feature/cedar-integration
Choose a base branch
from

Conversation

aaxelb
Copy link
Contributor

@aaxelb aaxelb commented Feb 1, 2024

Purpose

avoid headaches trying to make sense of silent errors after they've happened

Changes

add CedarMetadataRecord.clean to validate the record json using the template's jsonschema

QA Notes

Please make verification statements inspired by your code and what your code touches.

  • Verify
  • Verify

What are the areas of risk?

Any concerns/considerations/questions that development raised?

Documentation

Side Effects

Ticket

@cslzchen
Copy link
Contributor

cslzchen commented Feb 2, 2024

Just kicked off a re-run of api3_and_osf, the one test failed randomly on one of my PR as well.

Copy link
Contributor

@adlius adlius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it looks great and very straight forward. We need to verify this locally to make sure the CEDAR embeddable editor actually produces valid json that passes the JsonschemaValidator checks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants