Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new functions to Uri class #879

Merged
merged 2 commits into from
May 21, 2024
Merged

Add new functions to Uri class #879

merged 2 commits into from
May 21, 2024

Conversation

kring
Copy link
Member

@kring kring commented May 16, 2024

Adds several new functions to the Uri class:

  • unescape
  • unixPathToUriPath
  • windowsPathToUriPath
  • nativePathToUriPath
  • uriPathToUnixPath
  • uriPathToWindowsPath
  • uriPathToNativePath

csciguy8
csciguy8 reviewed May 20, 2024
View reviewed changes
Copy link
Contributor

@csciguy8 csciguy8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kring !

Looks like nice new functionality and tests. Had a couple comments that are optional if you'd like to act on them or not.

Otherwise, looks good to go.

CesiumUtility/src/Uri.cpp Show resolved Hide resolved
CesiumUtility/test/TestUri.cpp Show resolved Hide resolved
CesiumUtility/include/CesiumUtility/Uri.h Show resolved Hide resolved
@csciguy8 csciguy8 merged commit 9d5dbbb into main May 21, 2024
24 checks passed
@csciguy8 csciguy8 deleted the uri-functions branch May 21, 2024 14:56
@kring kring mentioned this pull request May 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csciguy8 csciguy8 csciguy8 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kring @csciguy8