Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix STB library conflicts #880

Merged
merged 3 commits into from
May 24, 2024
Merged

Fix STB library conflicts #880

merged 3 commits into from
May 24, 2024

Conversation

csciguy8
Copy link
Contributor

@csciguy8 csciguy8 commented May 17, 2024

Community contribution to fix an issue where cesium-native's use of the STB library can conflict with an application's use of it.

STB has more than one implementation that can be defined:

  • The community contribution solved a problem with STB_IMAGE_IMPLEMENTATION.
  • We solved a similar problem with STB_IMAGE_RESIZE_IMPLEMENTATION in Move stb resize function to Cesium namespace #871.
  • I additionally rounded this out by making STB_IMAGE_WRITE_IMPLEMENTATION static as well to avoid any similar issues in the future.

@kring
Copy link
Member

kring commented May 24, 2024

Thanks @csciguy8!

@kring kring merged commit 95bf682 into main May 24, 2024
24 checks passed
@kring kring deleted the no_stb_image_implementation branch May 24, 2024 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants