Merge pull request #11959 from CesiumGS/i3s-css

Fix leaking CSS styling
CesiumGS · Apr 30, 2024 · 1207d26 · 1207d26
2 parents 606574e + 8028c4b
commit 1207d26
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 9 deletions.
diff --git a/CHANGES.md b/CHANGES.md
@@ -6,7 +6,7 @@
 
 ##### Fixes :wrench:
 
-- Fixed a bug that Label position height may not be correctly updated when its HeightReference is relative. [#11929](https://github.com/CesiumGS/cesium/pull/11929)
+- Fixed leaked CSS styling from `I3SBuildingSceneLayerExplorer` widget. [#11959](https://github.com/CesiumGS/cesium/pull/11959)
 - Fixed a bug where a data source was not automatically rendered after is was added in request render mode. [#11934](https://github.com/CesiumGS/cesium/pull/11934)
 
 ### 1.116 - 2024-04-01

diff --git a/packages/widgets/Source/I3SBuildingSceneLayerExplorer/I3SBuildingSceneLayerExplorer.css b/packages/widgets/Source/I3SBuildingSceneLayerExplorer/I3SBuildingSceneLayerExplorer.css
@@ -1,30 +1,30 @@
-ul {
+.cesium-viewer-i3s-explorer ul {
   list-style-type: none;
 }
 
-.layersList {
+.cesium-viewer-i3s-explorer .layersList {
   padding: 0;
 }
 
-input {
+.cesium-viewer-i3s-explorer input {
   margin: 0 3px 0 0;
 }
-.expandItem {
+.cesium-viewer-i3s-explorer .expandItem {
   cursor: pointer;
   user-select: none;
   width: 20px;
 }
 
-.nested,
-#bsl-wrapper {
+.cesium-viewer-i3s-explorer .nested,
+.cesium-viewer-i3s-explorer #bsl-wrapper {
   display: none;
 }
 
-.active {
+.cesium-viewer-i3s-explorer .active {
   display: block;
 }
 
-.li-wrapper {
+.cesium-viewer-i3s-explorer .li-wrapper {
   display: flex;
   flex-direction: row;
   align-content: center;

diff --git a/packages/widgets/Source/I3SBuildingSceneLayerExplorer/I3SBuildingSceneLayerExplorer.js b/packages/widgets/Source/I3SBuildingSceneLayerExplorer/I3SBuildingSceneLayerExplorer.js
@@ -22,6 +22,7 @@ function I3SBuildingSceneLayerExplorer(containerId, i3sProvider) {
   //>>includeEnd('debug');
 
   const htmlWrapper = document.createElement("div");
+  htmlWrapper.classList.add("cesium-viewer-i3s-explorer");
   htmlWrapper.innerHTML = `
         <h3>Building explorer</h3>
         <select