Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

chore!: update puppeteer to version 19 #276

Merged
merged 6 commits into from Feb 13, 2023

Conversation

Lykhoyda
Copy link
Contributor

@Lykhoyda Lykhoyda commented Feb 9, 2023

Short description of work done

PR Checklist

  • I have run linter locally
  • I have run unit and integration tests locally
    • Update configuration the newest version (readme and const)
  • Rebased to master branch / merged master

Changes

Code updates based on breaking changes from puppeteer v15
puppeteer/puppeteer#8547

Issues

Closes #

@Lykhoyda Lykhoyda changed the title update puppeteer to version 15 chore: update puppeteer to version 19 Feb 10, 2023
@Lykhoyda Lykhoyda linked an issue Feb 10, 2023 that may be closed by this pull request
@Lykhoyda Lykhoyda marked this pull request as ready for review February 10, 2023 11:39
Copy link
Contributor

@BeroBurny BeroBurny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MIssing update on peerDependencies

@BeroBurny BeroBurny changed the title chore: update puppeteer to version 19 chore!: update puppeteer to version 19 Feb 10, 2023
Copy link
Contributor

@BeroBurny BeroBurny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Is soft approve if the rest is okay with version 19 I'm OK with it

Copy link
Contributor

@BeroBurny BeroBurny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems all are okay with this, merging

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update puppeteer peerDependencies
2 participants