Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use node 18 #4779

Merged
merged 9 commits into from Dec 12, 2022
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/cli/test/e2e/runDevCmd.test.ts
Expand Up @@ -9,11 +9,12 @@ describeCliTest("Run dev command", function ({spawnCli}) {
itDone("Run dev command with no --dataDir until beacon api is listening", async function (done) {
const beaconPort = 39011;

const devProc = spawnCli({pipeStdToParent: false, printOnlyOnError: true, logPrefix: "dev"}, [
const devProc = spawnCli({pipeStdToParent: true, printOnlyOnError: true, logPrefix: "dev"}, [
wemeetagain marked this conversation as resolved.
Show resolved Hide resolved
// ⏎
"dev",
"--reset",
"--startValidators=0..7",
"--logLevel=debug",
`--rest.port=${beaconPort}`,
]);

Expand Down
3 changes: 2 additions & 1 deletion packages/cli/test/e2e/voluntaryExit.test.ts
Expand Up @@ -13,13 +13,14 @@ describeCliTest("voluntaryExit cmd", function ({spawnCli}) {
itDone("Perform a voluntary exit", async function (done) {
const restPort = 9596;

const devBnProc = spawnCli({pipeStdToParent: false, logPrefix: "dev"}, [
const devBnProc = spawnCli({pipeStdToParent: true, logPrefix: "dev"}, [
// ⏎
"dev",
`--dataDir=${path.join(testFilesDir, "dev-voluntary-exit")}`,
"--genesisValidators=8",
"--startValidators=0..7",
"--rest",
"--logLevel=debug",
`--rest.port=${restPort}`,
// Speed up test to make genesis happen faster
"--params.SECONDS_PER_SLOT=2",
Expand Down