Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove remaining node16 references #4913

Merged
merged 1 commit into from Dec 16, 2022
Merged

Conversation

philknows
Copy link
Member

In addition to #4779 , this PR changes some text to instruct that users should always use latest LTS of nodeJS. Some badges also updated from node-16 to node-18.

@philknows philknows requested a review from a team as a code owner December 16, 2022 00:25
@wemeetagain wemeetagain enabled auto-merge (squash) December 16, 2022 00:38
@github-actions
Copy link
Contributor

Performance Report

✔️ no performance regression detected

Full benchmark results
Benchmark suite Current: 3fe42bd Previous: 95ef1d6 Ratio
getPubkeys - index2pubkey - req 1000 vs - 250000 vc 1.2795 ms/op 1.2681 ms/op 1.01
getPubkeys - validatorsArr - req 1000 vs - 250000 vc 74.175 us/op 75.683 us/op 0.98
BLS verify - blst-native 2.1169 ms/op 2.1282 ms/op 0.99
BLS verifyMultipleSignatures 3 - blst-native 4.5048 ms/op 4.1579 ms/op 1.08
BLS verifyMultipleSignatures 8 - blst-native 9.5869 ms/op 9.5108 ms/op 1.01
BLS verifyMultipleSignatures 32 - blst-native 33.661 ms/op 33.578 ms/op 1.00
BLS aggregatePubkeys 32 - blst-native 42.880 us/op 44.789 us/op 0.96
BLS aggregatePubkeys 128 - blst-native 174.34 us/op 172.76 us/op 1.01
getAttestationsForBlock 97.588 ms/op 97.986 ms/op 1.00
isKnown best case - 1 super set check 470.00 ns/op 481.00 ns/op 0.98
isKnown normal case - 2 super set checks 466.00 ns/op 497.00 ns/op 0.94
isKnown worse case - 16 super set checks 470.00 ns/op 492.00 ns/op 0.96
CheckpointStateCache - add get delete 9.3140 us/op 9.5650 us/op 0.97
validate gossip signedAggregateAndProof - struct 5.0190 ms/op 4.8340 ms/op 1.04
validate gossip attestation - struct 2.2565 ms/op 2.2945 ms/op 0.98
pickEth1Vote - no votes 2.3779 ms/op 2.2545 ms/op 1.05
pickEth1Vote - max votes 17.654 ms/op 18.202 ms/op 0.97
pickEth1Vote - Eth1Data hashTreeRoot value x2048 13.081 ms/op 12.310 ms/op 1.06
pickEth1Vote - Eth1Data hashTreeRoot tree x2048 22.171 ms/op 23.053 ms/op 0.96
pickEth1Vote - Eth1Data fastSerialize value x2048 1.3004 ms/op 1.2944 ms/op 1.00
pickEth1Vote - Eth1Data fastSerialize tree x2048 9.9853 ms/op 10.270 ms/op 0.97
bytes32 toHexString 1.1000 us/op 1.0950 us/op 1.00
bytes32 Buffer.toString(hex) 619.00 ns/op 595.00 ns/op 1.04
bytes32 Buffer.toString(hex) from Uint8Array 1.0080 us/op 978.00 ns/op 1.03
bytes32 Buffer.toString(hex) + 0x 598.00 ns/op 590.00 ns/op 1.01
Object access 1 prop 0.30500 ns/op 0.30000 ns/op 1.02
Map access 1 prop 0.29000 ns/op 0.29600 ns/op 0.98
Object get x1000 18.838 ns/op 20.129 ns/op 0.94
Map get x1000 1.1410 ns/op 1.1610 ns/op 0.98
Object set x1000 117.08 ns/op 117.01 ns/op 1.00
Map set x1000 71.958 ns/op 72.533 ns/op 0.99
Return object 10000 times 0.42310 ns/op 0.41470 ns/op 1.02
Throw Error 10000 times 7.6462 us/op 7.5104 us/op 1.02
fastMsgIdFn sha256 / 200 bytes 4.7570 us/op 4.7610 us/op 1.00
fastMsgIdFn h32 xxhash / 200 bytes 507.00 ns/op 519.00 ns/op 0.98
fastMsgIdFn h64 xxhash / 200 bytes 653.00 ns/op 682.00 ns/op 0.96
fastMsgIdFn sha256 / 1000 bytes 15.000 us/op 15.137 us/op 0.99
fastMsgIdFn h32 xxhash / 1000 bytes 647.00 ns/op 678.00 ns/op 0.95
fastMsgIdFn h64 xxhash / 1000 bytes 784.00 ns/op 738.00 ns/op 1.06
fastMsgIdFn sha256 / 10000 bytes 132.63 us/op 129.10 us/op 1.03
fastMsgIdFn h32 xxhash / 10000 bytes 2.5700 us/op 2.6550 us/op 0.97
fastMsgIdFn h64 xxhash / 10000 bytes 1.8330 us/op 1.9050 us/op 0.96
enrSubnets - fastDeserialize 64 bits 2.5140 us/op 2.5780 us/op 0.98
enrSubnets - ssz BitVector 64 bits 873.00 ns/op 902.00 ns/op 0.97
enrSubnets - fastDeserialize 4 bits 319.00 ns/op 348.00 ns/op 0.92
enrSubnets - ssz BitVector 4 bits 889.00 ns/op 911.00 ns/op 0.98
prioritizePeers score -10:0 att 32-0.1 sync 2-0 108.47 us/op 112.10 us/op 0.97
prioritizePeers score 0:0 att 32-0.25 sync 2-0.25 158.64 us/op 154.46 us/op 1.03
prioritizePeers score 0:0 att 32-0.5 sync 2-0.5 278.21 us/op 298.32 us/op 0.93
prioritizePeers score 0:0 att 64-0.75 sync 4-0.75 461.88 us/op 472.41 us/op 0.98
prioritizePeers score 0:0 att 64-1 sync 4-1 603.72 us/op 590.41 us/op 1.02
array of 16000 items push then shift 3.1168 us/op 3.2877 us/op 0.95
LinkedList of 16000 items push then shift 19.343 ns/op 19.553 ns/op 0.99
array of 16000 items push then pop 237.81 ns/op 244.18 ns/op 0.97
LinkedList of 16000 items push then pop 18.811 ns/op 18.493 ns/op 1.02
array of 24000 items push then shift 4.5581 us/op 4.3825 us/op 1.04
LinkedList of 24000 items push then shift 20.999 ns/op 23.689 ns/op 0.89
array of 24000 items push then pop 229.28 ns/op 232.85 ns/op 0.98
LinkedList of 24000 items push then pop 19.516 ns/op 20.660 ns/op 0.94
intersect bitArray bitLen 8 33.404 ns/op 33.429 ns/op 1.00
intersect array and set length 8 170.79 ns/op 177.33 ns/op 0.96
intersect bitArray bitLen 128 119.46 ns/op 122.73 ns/op 0.97
intersect array and set length 128 2.4543 us/op 2.5018 us/op 0.98
Buffer.concat 32 items 5.7970 us/op 5.9610 us/op 0.97
Uint8Array.set 32 items 4.2990 us/op 4.5710 us/op 0.94
pass gossip attestations to forkchoice per slot 4.9165 ms/op 4.6805 ms/op 1.05
computeDeltas 7.4945 ms/op 7.2841 ms/op 1.03
computeProposerBoostScoreFromBalances 3.0340 ms/op 3.0283 ms/op 1.00
altair processAttestation - 250000 vs - 7PWei normalcase 4.0371 ms/op 4.0744 ms/op 0.99
altair processAttestation - 250000 vs - 7PWei worstcase 6.4179 ms/op 6.9334 ms/op 0.93
altair processAttestation - setStatus - 1/6 committees join 234.29 us/op 318.43 us/op 0.74
altair processAttestation - setStatus - 1/3 committees join 453.19 us/op 613.51 us/op 0.74
altair processAttestation - setStatus - 1/2 committees join 658.43 us/op 822.89 us/op 0.80
altair processAttestation - setStatus - 2/3 committees join 837.69 us/op 1.0676 ms/op 0.78
altair processAttestation - setStatus - 4/5 committees join 1.1718 ms/op 1.4471 ms/op 0.81
altair processAttestation - setStatus - 100% committees join 1.3470 ms/op 1.7071 ms/op 0.79
altair processBlock - 250000 vs - 7PWei normalcase 28.951 ms/op 29.456 ms/op 0.98
altair processBlock - 250000 vs - 7PWei normalcase hashState 39.986 ms/op 41.880 ms/op 0.95
altair processBlock - 250000 vs - 7PWei worstcase 84.489 ms/op 84.959 ms/op 0.99
altair processBlock - 250000 vs - 7PWei worstcase hashState 105.83 ms/op 109.04 ms/op 0.97
phase0 processBlock - 250000 vs - 7PWei normalcase 3.7794 ms/op 3.7440 ms/op 1.01
phase0 processBlock - 250000 vs - 7PWei worstcase 49.901 ms/op 52.609 ms/op 0.95
altair processEth1Data - 250000 vs - 7PWei normalcase 840.65 us/op 872.08 us/op 0.96
vc - 250000 eb 1 eth1 1 we 0 wn 0 - smpl 15 15.014 us/op 14.353 us/op 1.05
vc - 250000 eb 0.95 eth1 0.1 we 0.05 wn 0 - smpl 219 46.557 us/op 51.997 us/op 0.90
vc - 250000 eb 0.95 eth1 0.3 we 0.05 wn 0 - smpl 42 22.054 us/op 26.119 us/op 0.84
vc - 250000 eb 0.95 eth1 0.7 we 0.05 wn 0 - smpl 18 19.788 us/op 20.667 us/op 0.96
vc - 250000 eb 0.1 eth1 0.1 we 0 wn 0 - smpl 1020 177.09 us/op 136.32 us/op 1.30
vc - 250000 eb 0.03 eth1 0.03 we 0 wn 0 - smpl 11777 1.2568 ms/op 1.3079 ms/op 0.96
vc - 250000 eb 0.01 eth1 0.01 we 0 wn 0 - smpl 141069 14.857 ms/op 14.781 ms/op 1.01
vc - 250000 eb 0 eth1 0 we 0 wn 0 - smpl 250000 25.630 ms/op 25.790 ms/op 0.99
vc - 250000 eb 0 eth1 0 we 0 wn 0 nocache - smpl 250000 84.587 ms/op 85.513 ms/op 0.99
vc - 250000 eb 0 eth1 1 we 0 wn 0 - smpl 250000 48.826 ms/op 54.325 ms/op 0.90
vc - 250000 eb 0 eth1 1 we 0 wn 0 nocache - smpl 250000 133.25 ms/op 137.13 ms/op 0.97
Tree 40 250000 create 724.19 ms/op 772.73 ms/op 0.94
Tree 40 250000 get(125000) 327.55 ns/op 328.84 ns/op 1.00
Tree 40 250000 set(125000) 2.1848 us/op 2.1792 us/op 1.00
Tree 40 250000 toArray() 33.428 ms/op 34.409 ms/op 0.97
Tree 40 250000 iterate all - toArray() + loop 34.454 ms/op 34.908 ms/op 0.99
Tree 40 250000 iterate all - get(i) 119.18 ms/op 121.57 ms/op 0.98
MutableVector 250000 create 16.225 ms/op 18.417 ms/op 0.88
MutableVector 250000 get(125000) 15.113 ns/op 15.063 ns/op 1.00
MutableVector 250000 set(125000) 619.33 ns/op 690.27 ns/op 0.90
MutableVector 250000 toArray() 7.2678 ms/op 6.9949 ms/op 1.04
MutableVector 250000 iterate all - toArray() + loop 7.3938 ms/op 7.3970 ms/op 1.00
MutableVector 250000 iterate all - get(i) 3.9245 ms/op 3.8716 ms/op 1.01
Array 250000 create 6.7044 ms/op 6.3317 ms/op 1.06
Array 250000 clone - spread 3.0417 ms/op 2.9796 ms/op 1.02
Array 250000 get(125000) 1.2940 ns/op 1.3480 ns/op 0.96
Array 250000 set(125000) 1.2630 ns/op 1.2810 ns/op 0.99
Array 250000 iterate all - loop 188.29 us/op 187.00 us/op 1.01
effectiveBalanceIncrements clone Uint8Array 300000 75.359 us/op 80.257 us/op 0.94
effectiveBalanceIncrements clone MutableVector 300000 933.00 ns/op 972.00 ns/op 0.96
effectiveBalanceIncrements rw all Uint8Array 300000 285.18 us/op 287.48 us/op 0.99
effectiveBalanceIncrements rw all MutableVector 300000 254.24 ms/op 215.49 ms/op 1.18
phase0 afterProcessEpoch - 250000 vs - 7PWei 214.88 ms/op 218.05 ms/op 0.99
phase0 beforeProcessEpoch - 250000 vs - 7PWei 79.073 ms/op 80.911 ms/op 0.98
altair processEpoch - mainnet_e81889 641.01 ms/op 660.52 ms/op 0.97
mainnet_e81889 - altair beforeProcessEpoch 169.80 ms/op 197.90 ms/op 0.86
mainnet_e81889 - altair processJustificationAndFinalization 30.507 us/op 36.658 us/op 0.83
mainnet_e81889 - altair processInactivityUpdates 12.176 ms/op 12.442 ms/op 0.98
mainnet_e81889 - altair processRewardsAndPenalties 101.43 ms/op 104.05 ms/op 0.97
mainnet_e81889 - altair processRegistryUpdates 10.293 us/op 8.4690 us/op 1.22
mainnet_e81889 - altair processSlashings 2.0850 us/op 2.3850 us/op 0.87
mainnet_e81889 - altair processEth1DataReset 1.9150 us/op 2.1040 us/op 0.91
mainnet_e81889 - altair processEffectiveBalanceUpdates 2.7794 ms/op 2.8507 ms/op 0.97
mainnet_e81889 - altair processSlashingsReset 13.749 us/op 15.460 us/op 0.89
mainnet_e81889 - altair processRandaoMixesReset 15.000 us/op 12.548 us/op 1.20
mainnet_e81889 - altair processHistoricalRootsUpdate 2.3280 us/op 2.5480 us/op 0.91
mainnet_e81889 - altair processParticipationFlagUpdates 9.3730 us/op 9.3140 us/op 1.01
mainnet_e81889 - altair processSyncCommitteeUpdates 1.9440 us/op 1.7600 us/op 1.10
mainnet_e81889 - altair afterProcessEpoch 219.43 ms/op 226.17 ms/op 0.97
phase0 processEpoch - mainnet_e58758 578.03 ms/op 598.27 ms/op 0.97
mainnet_e58758 - phase0 beforeProcessEpoch 241.64 ms/op 256.48 ms/op 0.94
mainnet_e58758 - phase0 processJustificationAndFinalization 39.106 us/op 33.915 us/op 1.15
mainnet_e58758 - phase0 processRewardsAndPenalties 126.23 ms/op 153.85 ms/op 0.82
mainnet_e58758 - phase0 processRegistryUpdates 25.082 us/op 24.463 us/op 1.03
mainnet_e58758 - phase0 processSlashings 1.9710 us/op 1.8180 us/op 1.08
mainnet_e58758 - phase0 processEth1DataReset 2.0490 us/op 1.8470 us/op 1.11
mainnet_e58758 - phase0 processEffectiveBalanceUpdates 2.3126 ms/op 2.4164 ms/op 0.96
mainnet_e58758 - phase0 processSlashingsReset 9.1720 us/op 10.462 us/op 0.88
mainnet_e58758 - phase0 processRandaoMixesReset 13.346 us/op 14.503 us/op 0.92
mainnet_e58758 - phase0 processHistoricalRootsUpdate 1.9850 us/op 2.0410 us/op 0.97
mainnet_e58758 - phase0 processParticipationRecordUpdates 12.385 us/op 12.090 us/op 1.02
mainnet_e58758 - phase0 afterProcessEpoch 184.79 ms/op 185.22 ms/op 1.00
phase0 processEffectiveBalanceUpdates - 250000 normalcase 3.3194 ms/op 3.3301 ms/op 1.00
phase0 processEffectiveBalanceUpdates - 250000 worstcase 0.5 3.4756 ms/op 3.7637 ms/op 0.92
altair processInactivityUpdates - 250000 normalcase 41.794 ms/op 44.976 ms/op 0.93
altair processInactivityUpdates - 250000 worstcase 50.700 ms/op 43.936 ms/op 1.15
phase0 processRegistryUpdates - 250000 normalcase 18.245 us/op 23.285 us/op 0.78
phase0 processRegistryUpdates - 250000 badcase_full_deposits 610.26 us/op 646.69 us/op 0.94
phase0 processRegistryUpdates - 250000 worstcase 0.5 231.97 ms/op 243.18 ms/op 0.95
altair processRewardsAndPenalties - 250000 normalcase 93.556 ms/op 97.432 ms/op 0.96
altair processRewardsAndPenalties - 250000 worstcase 141.95 ms/op 148.79 ms/op 0.95
phase0 getAttestationDeltas - 250000 normalcase 13.935 ms/op 13.744 ms/op 1.01
phase0 getAttestationDeltas - 250000 worstcase 14.057 ms/op 14.132 ms/op 0.99
phase0 processSlashings - 250000 worstcase 6.7921 ms/op 6.5586 ms/op 1.04
altair processSyncCommitteeUpdates - 250000 298.78 ms/op 299.34 ms/op 1.00
BeaconState.hashTreeRoot - No change 468.00 ns/op 529.00 ns/op 0.88
BeaconState.hashTreeRoot - 1 full validator 69.121 us/op 68.487 us/op 1.01
BeaconState.hashTreeRoot - 32 full validator 717.83 us/op 689.69 us/op 1.04
BeaconState.hashTreeRoot - 512 full validator 7.6197 ms/op 7.6674 ms/op 0.99
BeaconState.hashTreeRoot - 1 validator.effectiveBalance 89.064 us/op 88.171 us/op 1.01
BeaconState.hashTreeRoot - 32 validator.effectiveBalance 1.3498 ms/op 1.3856 ms/op 0.97
BeaconState.hashTreeRoot - 512 validator.effectiveBalance 17.961 ms/op 18.037 ms/op 1.00
BeaconState.hashTreeRoot - 1 balances 79.009 us/op 68.934 us/op 1.15
BeaconState.hashTreeRoot - 32 balances 620.36 us/op 1.7537 ms/op 0.35
BeaconState.hashTreeRoot - 512 balances 6.4132 ms/op 5.8756 ms/op 1.09
BeaconState.hashTreeRoot - 250000 balances 98.011 ms/op 98.638 ms/op 0.99
aggregationBits - 2048 els - zipIndexesInBitList 30.792 us/op 29.490 us/op 1.04
regular array get 100000 times 74.508 us/op 78.280 us/op 0.95
wrappedArray get 100000 times 76.766 us/op 74.089 us/op 1.04
arrayWithProxy get 100000 times 31.482 ms/op 32.046 ms/op 0.98
ssz.Root.equals 1.2010 us/op 1.2140 us/op 0.99
byteArrayEquals 1.2000 us/op 1.2530 us/op 0.96
shuffle list - 16384 els 12.978 ms/op 12.494 ms/op 1.04
shuffle list - 250000 els 186.89 ms/op 186.62 ms/op 1.00
processSlot - 1 slots 13.549 us/op 13.783 us/op 0.98
processSlot - 32 slots 1.9084 ms/op 1.9108 ms/op 1.00
getEffectiveBalanceIncrementsZeroInactive - 250000 vs - 7PWei 379.89 us/op 381.78 us/op 1.00
getCommitteeAssignments - req 1 vs - 250000 vc 7.1263 ms/op 6.2658 ms/op 1.14
getCommitteeAssignments - req 100 vs - 250000 vc 8.7860 ms/op 8.4299 ms/op 1.04
getCommitteeAssignments - req 1000 vs - 250000 vc 9.3296 ms/op 9.0505 ms/op 1.03
RootCache.getBlockRootAtSlot - 250000 vs - 7PWei 11.130 ns/op 11.020 ns/op 1.01
state getBlockRootAtSlot - 250000 vs - 7PWei 1.2773 us/op 1.2842 us/op 0.99
computeProposers - vc 250000 17.730 ms/op 18.137 ms/op 0.98
computeEpochShuffling - vc 250000 193.83 ms/op 199.33 ms/op 0.97
getNextSyncCommittee - vc 250000 300.74 ms/op 302.56 ms/op 0.99

by benchmarkbot/action

@wemeetagain wemeetagain merged commit 882c8e6 into unstable Dec 16, 2022
@wemeetagain wemeetagain deleted the philknows/remove-node16 branch December 16, 2022 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants