deps: update fastify to 4.19.0 #5726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nflaig
commented
Jun 30, 2023
| export class ApiError extends Error { | ||
| statusCode: number; | ||
| constructor(statusCode: number, message?: string) { | ||
| statusCode: HttpErrorCodes; |
There was a problem hiding this comment.
This change is required due to fastify/fastify#4823, if number type is used only a undefined payload can be passed to send(). Anyhow a good idea to narrow this type here down to only http error codes.
| // eslint-disable-next-line import/no-extraneous-dependencies | ||
| import type * as fastify from "fastify"; | ||
| import {ReqGeneric} from "../types.js"; | ||
|
|
||
| export type ServerInstance = FastifyInstance; | ||
|
|
||
| export type RouteConfig = { | ||
| export type RouteConfig = FastifyContextConfig & { |
There was a problem hiding this comment.
Required due to
Performance Report✔️ no performance regression detected Full benchmark results
|
wemeetagain
approved these changes
Jul 1, 2023
|
🎉 This PR is included in v1.10.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Keep dependencies up to date
Description
This update includes better error response if URI is too long which we had multiple times in the past