Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: downgrade cross-fetch to v3 #5806

Merged
merged 1 commit into from Jul 26, 2023
Merged

chore: downgrade cross-fetch to v3 #5806

merged 1 commit into from Jul 26, 2023

Conversation

wemeetagain
Copy link
Member

@wemeetagain wemeetagain commented Jul 26, 2023 •
edited by nflaig

Motivation

cross-fetch v4 causes browser issues

TypeError: Failed to execute 'fetch' on 'Window': Illegal invocation

and right now seems to be relatively low usage compared to v3, it is better to delay the update for a while.

Description

  • Downgrade cross-fetch to 3.1.8

@wemeetagain wemeetagain requested a review from a team as a code owner July 26, 2023 13:53
@github-actions
Copy link
Contributor

Performance Report

✔️ no performance regression detected

Full benchmark results
Benchmark suite Current: 6eb389c Previous: 26fd079 Ratio
getPubkeys - index2pubkey - req 1000 vs - 250000 vc 907.46 us/op 927.39 us/op 0.98
getPubkeys - validatorsArr - req 1000 vs - 250000 vc 84.841 us/op 73.669 us/op 1.15
BLS verify - blst-native 1.2454 ms/op 1.2020 ms/op 1.04
BLS verifyMultipleSignatures 3 - blst-native 2.5204 ms/op 2.4439 ms/op 1.03
BLS verifyMultipleSignatures 8 - blst-native 5.4266 ms/op 5.3485 ms/op 1.01
BLS verifyMultipleSignatures 32 - blst-native 19.488 ms/op 19.158 ms/op 1.02
BLS aggregatePubkeys 32 - blst-native 25.957 us/op 25.782 us/op 1.01
BLS aggregatePubkeys 128 - blst-native 101.47 us/op 100.14 us/op 1.01
getAttestationsForBlock 53.297 ms/op 54.211 ms/op 0.98
isKnown best case - 1 super set check 277.00 ns/op 283.00 ns/op 0.98
isKnown normal case - 2 super set checks 264.00 ns/op 285.00 ns/op 0.93
isKnown worse case - 16 super set checks 268.00 ns/op 273.00 ns/op 0.98
CheckpointStateCache - add get delete 5.0360 us/op 4.9340 us/op 1.02
validate api signedAggregateAndProof - struct 2.7865 ms/op 2.7675 ms/op 1.01
validate gossip signedAggregateAndProof - struct 2.8082 ms/op 2.7903 ms/op 1.01
validate api attestation - struct 1.3351 ms/op 1.3095 ms/op 1.02
validate gossip attestation - struct 1.3599 ms/op 1.3267 ms/op 1.03
pickEth1Vote - no votes 1.2389 ms/op 1.1708 ms/op 1.06
pickEth1Vote - max votes 9.1193 ms/op 13.869 ms/op 0.66
pickEth1Vote - Eth1Data hashTreeRoot value x2048 9.0897 ms/op 8.5705 ms/op 1.06
pickEth1Vote - Eth1Data hashTreeRoot tree x2048 13.650 ms/op 19.491 ms/op 0.70
pickEth1Vote - Eth1Data fastSerialize value x2048 593.11 us/op 587.90 us/op 1.01
pickEth1Vote - Eth1Data fastSerialize tree x2048 7.0326 ms/op 4.3486 ms/op 1.62
bytes32 toHexString 528.00 ns/op 492.00 ns/op 1.07
bytes32 Buffer.toString(hex) 313.00 ns/op 319.00 ns/op 0.98
bytes32 Buffer.toString(hex) from Uint8Array 446.00 ns/op 500.00 ns/op 0.89
bytes32 Buffer.toString(hex) + 0x 299.00 ns/op 346.00 ns/op 0.86
Object access 1 prop 0.18400 ns/op 0.16400 ns/op 1.12
Map access 1 prop 0.16000 ns/op 0.14900 ns/op 1.07
Object get x1000 7.6430 ns/op 7.1700 ns/op 1.07
Map get x1000 0.64800 ns/op 0.54400 ns/op 1.19
Object set x1000 53.801 ns/op 48.969 ns/op 1.10
Map set x1000 49.467 ns/op 39.839 ns/op 1.24
Return object 10000 times 0.25040 ns/op 0.23910 ns/op 1.05
Throw Error 10000 times 3.9814 us/op 3.8493 us/op 1.03
fastMsgIdFn sha256 / 200 bytes 3.4400 us/op 3.3110 us/op 1.04
fastMsgIdFn h32 xxhash / 200 bytes 338.00 ns/op 269.00 ns/op 1.26
fastMsgIdFn h64 xxhash / 200 bytes 378.00 ns/op 350.00 ns/op 1.08
fastMsgIdFn sha256 / 1000 bytes 11.684 us/op 11.183 us/op 1.04
fastMsgIdFn h32 xxhash / 1000 bytes 475.00 ns/op 388.00 ns/op 1.22
fastMsgIdFn h64 xxhash / 1000 bytes 438.00 ns/op 428.00 ns/op 1.02
fastMsgIdFn sha256 / 10000 bytes 104.68 us/op 102.42 us/op 1.02
fastMsgIdFn h32 xxhash / 10000 bytes 1.9940 us/op 1.9120 us/op 1.04
fastMsgIdFn h64 xxhash / 10000 bytes 1.3780 us/op 1.3200 us/op 1.04
enrSubnets - fastDeserialize 64 bits 1.2960 us/op 1.1900 us/op 1.09
enrSubnets - ssz BitVector 64 bits 452.00 ns/op 411.00 ns/op 1.10
enrSubnets - fastDeserialize 4 bits 181.00 ns/op 158.00 ns/op 1.15
enrSubnets - ssz BitVector 4 bits 427.00 ns/op 396.00 ns/op 1.08
prioritizePeers score -10:0 att 32-0.1 sync 2-0 99.811 us/op 96.333 us/op 1.04
prioritizePeers score 0:0 att 32-0.25 sync 2-0.25 133.63 us/op 120.05 us/op 1.11
prioritizePeers score 0:0 att 32-0.5 sync 2-0.5 175.19 us/op 155.02 us/op 1.13
prioritizePeers score 0:0 att 64-0.75 sync 4-0.75 328.93 us/op 281.28 us/op 1.17
prioritizePeers score 0:0 att 64-1 sync 4-1 359.55 us/op 334.03 us/op 1.08
array of 16000 items push then shift 1.6129 us/op 1.6084 us/op 1.00
LinkedList of 16000 items push then shift 9.1980 ns/op 9.0760 ns/op 1.01
array of 16000 items push then pop 82.596 ns/op 55.555 ns/op 1.49
LinkedList of 16000 items push then pop 9.3710 ns/op 8.8120 ns/op 1.06
array of 24000 items push then shift 2.4787 us/op 2.4823 us/op 1.00
LinkedList of 24000 items push then shift 9.1120 ns/op 9.1850 ns/op 0.99
array of 24000 items push then pop 120.98 ns/op 110.73 ns/op 1.09
LinkedList of 24000 items push then pop 12.281 ns/op 8.7040 ns/op 1.41
intersect bitArray bitLen 8 8.7430 ns/op 6.6740 ns/op 1.31
intersect array and set length 8 104.88 ns/op 53.689 ns/op 1.95
intersect bitArray bitLen 128 44.275 ns/op 31.558 ns/op 1.40
intersect array and set length 128 1.0333 us/op 730.77 ns/op 1.41
bitArray.getTrueBitIndexes() bitLen 128 1.8030 us/op 1.4670 us/op 1.23
bitArray.getTrueBitIndexes() bitLen 248 3.0950 us/op 2.3700 us/op 1.31
bitArray.getTrueBitIndexes() bitLen 512 6.0520 us/op 4.5290 us/op 1.34
Buffer.concat 32 items 1.1330 us/op 937.00 ns/op 1.21
Uint8Array.set 32 items 1.9540 us/op 2.2380 us/op 0.87
transfer serialized Status (84 B) 1.9800 us/op 1.9830 us/op 1.00
copy serialized Status (84 B) 1.7310 us/op 1.6120 us/op 1.07
transfer serialized SignedVoluntaryExit (112 B) 2.0970 us/op 2.0870 us/op 1.00
copy serialized SignedVoluntaryExit (112 B) 1.7530 us/op 1.6150 us/op 1.09
transfer serialized ProposerSlashing (416 B) 2.6600 us/op 2.3610 us/op 1.13
copy serialized ProposerSlashing (416 B) 2.2980 us/op 2.0160 us/op 1.14
transfer serialized Attestation (485 B) 2.2160 us/op 3.2620 us/op 0.68
copy serialized Attestation (485 B) 1.9430 us/op 2.3490 us/op 0.83
transfer serialized AttesterSlashing (33232 B) 2.1890 us/op 3.2050 us/op 0.68
copy serialized AttesterSlashing (33232 B) 5.1020 us/op 5.8820 us/op 0.87
transfer serialized Small SignedBeaconBlock (128000 B) 4.0460 us/op 3.1160 us/op 1.30
copy serialized Small SignedBeaconBlock (128000 B) 36.259 us/op 12.974 us/op 2.79
transfer serialized Avg SignedBeaconBlock (200000 B) 4.4450 us/op 3.4890 us/op 1.27
copy serialized Avg SignedBeaconBlock (200000 B) 55.289 us/op 18.690 us/op 2.96
transfer serialized BlobsSidecar (524380 B) 6.3380 us/op 3.3310 us/op 1.90
copy serialized BlobsSidecar (524380 B) 162.52 us/op 87.897 us/op 1.85
transfer serialized Big SignedBeaconBlock (1000000 B) 7.9230 us/op 3.3010 us/op 2.40
copy serialized Big SignedBeaconBlock (1000000 B) 288.03 us/op 159.36 us/op 1.81
pass gossip attestations to forkchoice per slot 2.2008 ms/op 2.2092 ms/op 1.00
forkChoice updateHead vc 100000 bc 64 eq 0 2.1556 ms/op 2.3780 ms/op 0.91
forkChoice updateHead vc 600000 bc 64 eq 0 13.972 ms/op 13.717 ms/op 1.02
forkChoice updateHead vc 1000000 bc 64 eq 0 23.529 ms/op 22.801 ms/op 1.03
forkChoice updateHead vc 600000 bc 320 eq 0 23.008 ms/op 16.666 ms/op 1.38
forkChoice updateHead vc 600000 bc 1200 eq 0 126.74 ms/op 89.797 ms/op 1.41
forkChoice updateHead vc 600000 bc 64 eq 1000 22.666 ms/op 22.477 ms/op 1.01
forkChoice updateHead vc 600000 bc 64 eq 10000 24.929 ms/op 23.603 ms/op 1.06
forkChoice updateHead vc 600000 bc 64 eq 300000 34.375 ms/op 29.472 ms/op 1.17
computeDeltas 3.1062 ms/op 4.2524 ms/op 0.73
computeProposerBoostScoreFromBalances 400.95 us/op 386.25 us/op 1.04
altair processAttestation - 250000 vs - 7PWei normalcase 2.5746 ms/op 2.1525 ms/op 1.20
altair processAttestation - 250000 vs - 7PWei worstcase 3.4867 ms/op 3.3281 ms/op 1.05
altair processAttestation - setStatus - 1/6 committees join 226.43 us/op 203.11 us/op 1.11
altair processAttestation - setStatus - 1/3 committees join 418.36 us/op 383.60 us/op 1.09
altair processAttestation - setStatus - 1/2 committees join 622.73 us/op 471.43 us/op 1.32
altair processAttestation - setStatus - 2/3 committees join 797.27 us/op 581.76 us/op 1.37
altair processAttestation - setStatus - 4/5 committees join 1.4679 ms/op 789.60 us/op 1.86
altair processAttestation - setStatus - 100% committees join 1.7653 ms/op 902.33 us/op 1.96
altair processBlock - 250000 vs - 7PWei normalcase 11.173 ms/op 9.3612 ms/op 1.19
altair processBlock - 250000 vs - 7PWei normalcase hashState 19.416 ms/op 18.138 ms/op 1.07
altair processBlock - 250000 vs - 7PWei worstcase 40.601 ms/op 40.028 ms/op 1.01
altair processBlock - 250000 vs - 7PWei worstcase hashState 63.265 ms/op 62.882 ms/op 1.01
phase0 processBlock - 250000 vs - 7PWei normalcase 2.2216 ms/op 2.8823 ms/op 0.77
phase0 processBlock - 250000 vs - 7PWei worstcase 31.331 ms/op 35.153 ms/op 0.89
altair processEth1Data - 250000 vs - 7PWei normalcase 649.76 us/op 567.45 us/op 1.15
getExpectedWithdrawals 250000 eb:1,eth1:1,we:0,wn:0,smpl:15 15.544 us/op 15.729 us/op 0.99
getExpectedWithdrawals 250000 eb:0.95,eth1:0.1,we:0.05,wn:0,smpl:219 44.469 us/op 89.116 us/op 0.50
getExpectedWithdrawals 250000 eb:0.95,eth1:0.3,we:0.05,wn:0,smpl:42 53.602 us/op 29.137 us/op 1.84
getExpectedWithdrawals 250000 eb:0.95,eth1:0.7,we:0.05,wn:0,smpl:18 29.084 us/op 16.608 us/op 1.75
getExpectedWithdrawals 250000 eb:0.1,eth1:0.1,we:0,wn:0,smpl:1020 257.12 us/op 188.27 us/op 1.37
getExpectedWithdrawals 250000 eb:0.03,eth1:0.03,we:0,wn:0,smpl:11777 1.4364 ms/op 1.6537 ms/op 0.87
getExpectedWithdrawals 250000 eb:0.01,eth1:0.01,we:0,wn:0,smpl:16384 1.9417 ms/op 1.9816 ms/op 0.98
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,smpl:16384 1.7041 ms/op 1.9105 ms/op 0.89
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,nocache,smpl:16384 3.8847 ms/op 3.8236 ms/op 1.02
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,smpl:16384 2.9157 ms/op 3.1637 ms/op 0.92
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,nocache,smpl:16384 6.6216 ms/op 5.4298 ms/op 1.22
Tree 40 250000 create 444.87 ms/op 305.59 ms/op 1.46
Tree 40 250000 get(125000) 213.00 ns/op 199.05 ns/op 1.07
Tree 40 250000 set(125000) 1.0081 us/op 892.52 ns/op 1.13
Tree 40 250000 toArray() 22.389 ms/op 19.011 ms/op 1.18
Tree 40 250000 iterate all - toArray() + loop 23.489 ms/op 19.106 ms/op 1.23
Tree 40 250000 iterate all - get(i) 76.148 ms/op 69.440 ms/op 1.10
MutableVector 250000 create 9.8550 ms/op 15.050 ms/op 0.65
MutableVector 250000 get(125000) 6.8820 ns/op 6.5870 ns/op 1.04
MutableVector 250000 set(125000) 277.02 ns/op 236.38 ns/op 1.17
MutableVector 250000 toArray() 2.9455 ms/op 2.5970 ms/op 1.13
MutableVector 250000 iterate all - toArray() + loop 3.0263 ms/op 3.0039 ms/op 1.01
MutableVector 250000 iterate all - get(i) 1.6176 ms/op 1.5444 ms/op 1.05
Array 250000 create 2.8626 ms/op 2.6992 ms/op 1.06
Array 250000 clone - spread 1.0902 ms/op 994.81 us/op 1.10
Array 250000 get(125000) 0.55000 ns/op 0.50600 ns/op 1.09
Array 250000 set(125000) 0.62100 ns/op 0.56900 ns/op 1.09
Array 250000 iterate all - loop 110.69 us/op 81.876 us/op 1.35
effectiveBalanceIncrements clone Uint8Array 300000 31.388 us/op 21.499 us/op 1.46
effectiveBalanceIncrements clone MutableVector 300000 321.00 ns/op 270.00 ns/op 1.19
effectiveBalanceIncrements rw all Uint8Array 300000 183.43 us/op 176.98 us/op 1.04
effectiveBalanceIncrements rw all MutableVector 300000 93.738 ms/op 75.310 ms/op 1.24
phase0 afterProcessEpoch - 250000 vs - 7PWei 119.62 ms/op 115.09 ms/op 1.04
phase0 beforeProcessEpoch - 250000 vs - 7PWei 41.976 ms/op 44.052 ms/op 0.95
altair processEpoch - mainnet_e81889 329.88 ms/op 356.49 ms/op 0.93
mainnet_e81889 - altair beforeProcessEpoch 61.692 ms/op 62.780 ms/op 0.98
mainnet_e81889 - altair processJustificationAndFinalization 14.021 us/op 15.917 us/op 0.88
mainnet_e81889 - altair processInactivityUpdates 5.3795 ms/op 6.2032 ms/op 0.87
mainnet_e81889 - altair processRewardsAndPenalties 64.341 ms/op 68.118 ms/op 0.94
mainnet_e81889 - altair processRegistryUpdates 2.7960 us/op 4.8470 us/op 0.58
mainnet_e81889 - altair processSlashings 435.00 ns/op 560.00 ns/op 0.78
mainnet_e81889 - altair processEth1DataReset 711.00 ns/op 553.00 ns/op 1.29
mainnet_e81889 - altair processEffectiveBalanceUpdates 1.3068 ms/op 1.2900 ms/op 1.01
mainnet_e81889 - altair processSlashingsReset 3.6670 us/op 3.3210 us/op 1.10
mainnet_e81889 - altair processRandaoMixesReset 6.6410 us/op 5.7120 us/op 1.16
mainnet_e81889 - altair processHistoricalRootsUpdate 848.00 ns/op 762.00 ns/op 1.11
mainnet_e81889 - altair processParticipationFlagUpdates 3.5420 us/op 2.1350 us/op 1.66
mainnet_e81889 - altair processSyncCommitteeUpdates 892.00 ns/op 782.00 ns/op 1.14
mainnet_e81889 - altair afterProcessEpoch 129.99 ms/op 136.62 ms/op 0.95
phase0 processEpoch - mainnet_e58758 472.39 ms/op 380.36 ms/op 1.24
mainnet_e58758 - phase0 beforeProcessEpoch 138.39 ms/op 149.55 ms/op 0.93
mainnet_e58758 - phase0 processJustificationAndFinalization 16.389 us/op 15.663 us/op 1.05
mainnet_e58758 - phase0 processRewardsAndPenalties 71.396 ms/op 69.702 ms/op 1.02
mainnet_e58758 - phase0 processRegistryUpdates 9.5900 us/op 14.155 us/op 0.68
mainnet_e58758 - phase0 processSlashings 496.00 ns/op 714.00 ns/op 0.69
mainnet_e58758 - phase0 processEth1DataReset 461.00 ns/op 401.00 ns/op 1.15
mainnet_e58758 - phase0 processEffectiveBalanceUpdates 1.0969 ms/op 1.2837 ms/op 0.85
mainnet_e58758 - phase0 processSlashingsReset 6.5870 us/op 2.7430 us/op 2.40
mainnet_e58758 - phase0 processRandaoMixesReset 5.5010 us/op 4.0020 us/op 1.37
mainnet_e58758 - phase0 processHistoricalRootsUpdate 478.00 ns/op 475.00 ns/op 1.01
mainnet_e58758 - phase0 processParticipationRecordUpdates 3.2720 us/op 3.4720 us/op 0.94
mainnet_e58758 - phase0 afterProcessEpoch 107.53 ms/op 108.63 ms/op 0.99
phase0 processEffectiveBalanceUpdates - 250000 normalcase 1.2657 ms/op 1.4952 ms/op 0.85
phase0 processEffectiveBalanceUpdates - 250000 worstcase 0.5 1.6152 ms/op 1.7256 ms/op 0.94
altair processInactivityUpdates - 250000 normalcase 27.671 ms/op 28.942 ms/op 0.96
altair processInactivityUpdates - 250000 worstcase 25.458 ms/op 27.061 ms/op 0.94
phase0 processRegistryUpdates - 250000 normalcase 7.5860 us/op 12.078 us/op 0.63
phase0 processRegistryUpdates - 250000 badcase_full_deposits 333.52 us/op 420.16 us/op 0.79
phase0 processRegistryUpdates - 250000 worstcase 0.5 119.54 ms/op 132.95 ms/op 0.90
altair processRewardsAndPenalties - 250000 normalcase 65.350 ms/op 82.325 ms/op 0.79
altair processRewardsAndPenalties - 250000 worstcase 66.245 ms/op 72.308 ms/op 0.92
phase0 getAttestationDeltas - 250000 normalcase 7.7730 ms/op 7.7857 ms/op 1.00
phase0 getAttestationDeltas - 250000 worstcase 7.8480 ms/op 8.1855 ms/op 0.96
phase0 processSlashings - 250000 worstcase 2.4099 ms/op 2.2417 ms/op 1.08
altair processSyncCommitteeUpdates - 250000 150.04 ms/op 163.17 ms/op 0.92
BeaconState.hashTreeRoot - No change 289.00 ns/op 280.00 ns/op 1.03
BeaconState.hashTreeRoot - 1 full validator 50.297 us/op 54.166 us/op 0.93
BeaconState.hashTreeRoot - 32 full validator 492.87 us/op 488.77 us/op 1.01
BeaconState.hashTreeRoot - 512 full validator 5.1371 ms/op 6.2047 ms/op 0.83
BeaconState.hashTreeRoot - 1 validator.effectiveBalance 62.580 us/op 68.283 us/op 0.92
BeaconState.hashTreeRoot - 32 validator.effectiveBalance 867.43 us/op 943.47 us/op 0.92
BeaconState.hashTreeRoot - 512 validator.effectiveBalance 10.772 ms/op 12.434 ms/op 0.87
BeaconState.hashTreeRoot - 1 balances 47.773 us/op 54.036 us/op 0.88
BeaconState.hashTreeRoot - 32 balances 434.86 us/op 528.10 us/op 0.82
BeaconState.hashTreeRoot - 512 balances 3.9421 ms/op 4.7380 ms/op 0.83
BeaconState.hashTreeRoot - 250000 balances 75.508 ms/op 80.669 ms/op 0.94
aggregationBits - 2048 els - zipIndexesInBitList 15.256 us/op 14.677 us/op 1.04
regular array get 100000 times 39.902 us/op 33.742 us/op 1.18
wrappedArray get 100000 times 33.533 us/op 35.691 us/op 0.94
arrayWithProxy get 100000 times 14.598 ms/op 15.708 ms/op 0.93
ssz.Root.equals 202.00 ns/op 203.00 ns/op 1.00
byteArrayEquals 212.00 ns/op 204.00 ns/op 1.04
shuffle list - 16384 els 7.0229 ms/op 7.0301 ms/op 1.00
shuffle list - 250000 els 102.85 ms/op 103.19 ms/op 1.00
processSlot - 1 slots 7.8330 us/op 8.5400 us/op 0.92
processSlot - 32 slots 1.3101 ms/op 1.3224 ms/op 0.99
getEffectiveBalanceIncrementsZeroInactive - 250000 vs - 7PWei 58.944 ms/op 55.846 ms/op 1.06
getCommitteeAssignments - req 1 vs - 250000 vc 2.5767 ms/op 2.5045 ms/op 1.03
getCommitteeAssignments - req 100 vs - 250000 vc 3.8174 ms/op 3.6597 ms/op 1.04
getCommitteeAssignments - req 1000 vs - 250000 vc 4.1141 ms/op 4.0253 ms/op 1.02
RootCache.getBlockRootAtSlot - 250000 vs - 7PWei 10.370 ns/op 4.5200 ns/op 2.29
state getBlockRootAtSlot - 250000 vs - 7PWei 1.0183 us/op 521.57 ns/op 1.95
computeProposers - vc 250000 16.425 ms/op 8.5433 ms/op 1.92
computeEpochShuffling - vc 250000 133.21 ms/op 104.62 ms/op 1.27
getNextSyncCommittee - vc 250000 171.34 ms/op 144.06 ms/op 1.19
computeSigningRoot for AttestationData 14.646 us/op 12.154 us/op 1.21
hash AttestationData serialized data then Buffer.toString(base64) 2.5886 us/op 2.3010 us/op 1.12
toHexString serialized data 1.1967 us/op 1.0870 us/op 1.10
Buffer.toString(base64) 250.43 ns/op 241.86 ns/op 1.04

by benchmarkbot/action

matthewkeil
matthewkeil approved these changes Jul 26, 2023
View reviewed changes
Copy link
Member

@matthewkeil matthewkeil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🚀

@nflaig
Copy link
Member

nflaig commented Jul 26, 2023

Downgrading cross-fetch for now is good but this does not resolve #5765. Still need to update node-fetch to a version that has the fix applied. Ideally, we want them to backport it to v2.

@nflaig nflaig changed the title chore: downgrade cross-fetch chore: downgrade cross-fetch v3 Jul 26, 2023
@nflaig nflaig changed the title chore: downgrade cross-fetch v3 chore: downgrade cross-fetch to v3 Jul 26, 2023
@nflaig nflaig merged commit 201dfc8 into unstable Jul 26, 2023
15 checks passed
@nflaig nflaig deleted the cayman/downgrade-cross-fetch branch July 26, 2023 17:40
@wemeetagain
Copy link
Member Author

🎉 This PR is included in v1.10.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewkeil matthewkeil matthewkeil approved these changes

@nflaig nflaig nflaig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wemeetagain @nflaig @matthewkeil