Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add retry option for segfault #6161

Merged
merged 1 commit into from Dec 6, 2023
Merged

Conversation

nazarhussain
Copy link
Contributor

@nazarhussain nazarhussain commented Dec 6, 2023

Motivation

Make the CI more stable.

Description

Make the CI server more stable and avoid re-running the tests manually on segfaults

Some references are:
vitejs/vite#9492
vitest-dev/vitest#1854
nodejs/node#43617

Steps to test or reproduce

Run all tests.

@nazarhussain nazarhussain marked this pull request as ready for review December 6, 2023 12:04
@nazarhussain nazarhussain requested a review from a team as a code owner December 6, 2023 12:04
@nazarhussain nazarhussain self-assigned this Dec 6, 2023
Copy link
Member

@nflaig nflaig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be sufficient workaround for now, tests usually pass on second run.

@nazarhussain nazarhussain merged commit 4b9647f into unstable Dec 6, 2023
14 of 16 checks passed
@nazarhussain nazarhussain deleted the nh/fix-unit-tests branch December 6, 2023 14:17
jeluard pushed a commit that referenced this pull request Dec 7, 2023
@wemeetagain
Copy link
Member

🎉 This PR is included in v1.13.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants