Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: switch from snappy to snappyjs #15

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from
Draft

feat: switch from snappy to snappyjs #15

wants to merge 7 commits into from

Conversation

twoeths
Copy link

@twoeths twoeths commented Aug 26, 2022 •
edited

Motivation

  • Lodestar already used snappyjs so there is no need to introduce another dependency with same purpose
  • Lodestar only uses sync api
  • There's an external memory leak issue when we upgrade to esm, switching to snappyjs help reduce the risk because snappy calls to native layer

Description

  • Switch from tap to mocha
  • Switch from snappy to snappyjs
  • Remove asyncCompress option, only support sync api
  • migrate to esm
  • remove buffer-* dependencies

@twoeths twoeths changed the title Switch from tap to mocha feat: switch from tap to mocha Aug 26, 2022
@twoeths twoeths changed the title feat: switch from tap to mocha feat: switch from snappy to snappyjs Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@twoeths