Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(query): versionning and logging query failing on aws bucket with count #6847

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

fix(query): versionning and logging query failing on aws bucket with count #6847

wants to merge 5 commits into from

Conversation

embaya
Copy link

@embaya embaya commented Jan 9, 2024

Context

To follow up on this fix #6070

Why

When an s3 bucket and its versioning and logging configuration use count, the request is evaluated to true (false positive). (AWS v4 provider)

Proposed Changes

  • Add has_associated_logging function to check whether a specific S3 bucket is associated with a given configuration in a document.
  • Add has_associated_versioning function to check whether a specific S3 bucket is associated with a given configuration in a document.
  • fix code indentation in the modified files by using of tabs instead of 4 spaces

How to test

  • Comment one of the two lines associated with test function calls for each type of configuration

I submit this contribution under the Apache-2.0 license.

@github-actions github-actions bot added community Community contribution query New query feature terraform Terraform query aws PR related with AWS Cloud labels Jan 9, 2024
@embaya embaya changed the title fix(terraform/aws): s3 versionning and logging query failing on bucket with count fix(terraform/aws): versionning and logging query failing on s3 bucket with count Jan 9, 2024
@embaya embaya changed the title fix(terraform/aws): versionning and logging query failing on s3 bucket with count fix(terraform/aws): versionning and logging query failing on bucket with count Jan 9, 2024
@embaya embaya changed the title fix(terraform/aws): versionning and logging query failing on bucket with count fix(query): versionning and logging query failing on aws bucket with count Jan 9, 2024
@github-actions github-actions bot removed the terraform Terraform query label Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabriel-cx gabriel-cx Awaiting requested review from gabriel-cx gabriel-cx is a code owner

@cxMiguelSilva cxMiguelSilva Awaiting requested review from cxMiguelSilva cxMiguelSilva is a code owner

@JoaoCxMartins JoaoCxMartins Awaiting requested review from JoaoCxMartins JoaoCxMartins is a code owner

@EduardoSemanas EduardoSemanas Awaiting requested review from EduardoSemanas EduardoSemanas is a code owner

@cx-ruiaraujo cx-ruiaraujo Awaiting requested review from cx-ruiaraujo cx-ruiaraujo is a code owner

@asofsilva asofsilva Awaiting requested review from asofsilva asofsilva is a code owner

@cx-andrep cx-andrep Awaiting requested review from cx-andrep cx-andrep is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
aws PR related with AWS Cloud community Community contribution query New query feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@embaya