Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(secrets): refactor secret detection and masking mechanism #6858

Open
wants to merge 17 commits into
base: master
Choose a base branch
from

Conversation

pereiramarco011
Copy link
Collaborator

Closes #

Proposed Changes

  • Remove special mask (replaced with groupMask)
  • remove multiline struct (replaced with simple boolean)
  • add groupMask to all regexes

I submit this contribution under the Apache-2.0 license.

Copy link
Contributor

github-actions bot commented Jan 26, 2024

kics-logo

KICS version: v1.7.12

Category Results
HIGH HIGH 0
MEDIUM MEDIUM 0
LOW LOW 0
INFO INFO 0
TRACE TRACE 0
TOTAL TOTAL 0
Metric Values
Files scanned placeholder 1
Files parsed placeholder 1
Files failed to scan placeholder 0
Total executed queries placeholder 49
Queries failed to execute placeholder 0
Execution time placeholder 1

@pereiramarco011 pereiramarco011 changed the title refactor kics secrets detection and masking refactor(secrets): refactor secret detection and masking mechanism Jan 29, 2024
@Checkmarx Checkmarx deleted a comment from gitguardian bot Jan 29, 2024
Copy link

gitguardian bot commented Jan 29, 2024

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
- Generic Password 373d689 pkg/engine/secrets/inspector_test.go View secret
- Generic Password 373d689 pkg/engine/secrets/inspector_test.go View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants