Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(engine): similarity id improve #6970

Merged
merged 63 commits into from
May 16, 2024
Merged

feat(engine): similarity id improve #6970

merged 63 commits into from
May 16, 2024

Conversation

JoaoCxMartins
Copy link
Collaborator

@JoaoCxMartins JoaoCxMartins commented Mar 25, 2024

Closes #

Proposed Changes

  • a new way to calculate the similarity id
  • improve e2e not to allow duplicate similarity id
  • implement new scan argument kics_compute_new_simid

I submit this contribution under the Apache-2.0 license.

@github-actions github-actions bot added the feature New feature label Mar 25, 2024
Copy link
Contributor

github-actions bot commented Mar 25, 2024

kics-logo

KICS version: v2.0.1

Category Results
CRITICAL CRITICAL 0
HIGH HIGH 0
MEDIUM MEDIUM 0
LOW LOW 0
INFO INFO 0
TRACE TRACE 0
TOTAL TOTAL 0
Metric Values
Files scanned placeholder 1
Files parsed placeholder 1
Files failed to scan placeholder 0
Total executed queries placeholder 48
Queries failed to execute placeholder 0
Execution time placeholder 0

# Conflicts:
#	e2e/fixtures/E2E_CLI_093_RESULT.json
#	e2e/fixtures/E2E_CLI_093_RESULT_2.json
#	e2e/fixtures/E2E_CLI_093_RESULT_3.json
#	e2e/fixtures/E2E_CLI_093_RESULT_4.json
#	e2e/fixtures/E2E_CLI_093_RESULT_5.json
cxMiguelSilva
cxMiguelSilva previously approved these changes Mar 27, 2024
# Conflicts:
#	e2e/fixtures/E2E_CLI_032_RESULT.json
#	e2e/fixtures/E2E_CLI_036_RESULT.json
#	e2e/fixtures/E2E_CLI_072_RESULT.json
#	e2e/fixtures/E2E_CLI_077_RESULT.json
#	e2e/fixtures/E2E_CLI_081_RESULT.json
#	e2e/fixtures/E2E_CLI_086_RESULT.json
#	e2e/fixtures/E2E_CLI_087_RESULT.json
#	e2e/fixtures/E2E_CLI_088_RESULT.json
cxMiguelSilva
cxMiguelSilva previously approved these changes May 3, 2024
@cx-andrep cx-andrep merged commit 9fca6c8 into master May 16, 2024
26 checks passed
@cx-andrep cx-andrep deleted the joaom/kics-1361 branch May 16, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants