Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(query): tf mfa delete doing checks out of its scope #7051

Merged
merged 13 commits into from
May 20, 2024
Merged

fix(query): tf mfa delete doing checks out of its scope #7051

merged 13 commits into from
May 20, 2024

Conversation

JulioSCX
Copy link
Contributor

Proposed Changes

  • S3 Bucket Without Enabled MFA Delete query unnecessarily checking for versioning

I submit this contribution under the Apache-2.0 license.

@github-actions github-actions bot added query New query feature terraform Terraform query labels May 13, 2024
@github-actions GitHub Actions
Copy link
Contributor

kics-logo

KICS version: v2.0.1

Category Results
CRITICAL CRITICAL 0
HIGH HIGH 0
MEDIUM MEDIUM 0
LOW LOW 0
INFO INFO 0
TRACE TRACE 0
TOTAL TOTAL 0
Metric Values
Files scanned placeholder 1
Files parsed placeholder 1
Files failed to scan placeholder 0
Total executed queries placeholder 48
Queries failed to execute placeholder 0
Execution time placeholder 0

cx-ruiaraujo
cx-ruiaraujo approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@cx-ruiaraujo cx-ruiaraujo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cx-andrep cx-andrep merged commit 142d2cf into master May 20, 2024
26 checks passed
@cx-andrep cx-andrep deleted the AST-42523 branch May 20, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cx-ruiaraujo cx-ruiaraujo cx-ruiaraujo approved these changes

@gabriel-cx gabriel-cx Awaiting requested review from gabriel-cx gabriel-cx is a code owner

@cxMiguelSilva cxMiguelSilva Awaiting requested review from cxMiguelSilva cxMiguelSilva is a code owner

@JoaoCxMartins JoaoCxMartins Awaiting requested review from JoaoCxMartins JoaoCxMartins is a code owner

@EduardoSemanas EduardoSemanas Awaiting requested review from EduardoSemanas EduardoSemanas is a code owner

@asofsilva asofsilva Awaiting requested review from asofsilva asofsilva is a code owner

@cx-andrep cx-andrep Awaiting requested review from cx-andrep cx-andrep is a code owner

Assignees
No one assigned
Labels
query New query feature terraform Terraform query
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@JulioSCX @cx-ruiaraujo @cx-andrep @ArturRibeiro-CX @gabriel-cx