Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(query): fix bugs and small improvements to TF queries #7052

Merged
merged 7 commits into from
May 17, 2024
Merged

fix(query): fix bugs and small improvements to TF queries #7052

merged 7 commits into from
May 17, 2024

Conversation

ArturRibeiro-CX
Copy link
Contributor

@ArturRibeiro-CX ArturRibeiro-CX commented May 14, 2024 •
edited

Proposed Changes

  • renamed folder network_interfaces_dont_use_public_ip to network_interfaces_with_public_ip for better clarity;
  • fixed ec2_instance_monitoring_disabled key actual and expected results;
  • fixed lambda_iam_invokefunction_misconfigured key actual and expected results;

I submit this contribution under the Apache-2.0 license.

@github-actions github-actions bot added bug Something isn't working query New query feature terraform Terraform query labels May 14, 2024
@github-actions GitHub Actions
Copy link
Contributor

kics-logo

KICS version: v2.0.1

Category Results
CRITICAL CRITICAL 0
HIGH HIGH 0
MEDIUM MEDIUM 0
LOW LOW 0
INFO INFO 0
TRACE TRACE 0
TOTAL TOTAL 0
Metric Values
Files scanned placeholder 1
Files parsed placeholder 1
Files failed to scan placeholder 0
Total executed queries placeholder 48
Queries failed to execute placeholder 0
Execution time placeholder 0

@ArturRibeiro-CX ArturRibeiro-CX marked this pull request as ready for review May 14, 2024 14:49
@cx-andrep cx-andrep merged commit d342f4c into master May 17, 2024
27 checks passed
@cx-andrep cx-andrep deleted the AST-40641 branch May 17, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabriel-cx gabriel-cx gabriel-cx approved these changes

@cxMiguelSilva cxMiguelSilva Awaiting requested review from cxMiguelSilva cxMiguelSilva is a code owner

@JoaoCxMartins JoaoCxMartins Awaiting requested review from JoaoCxMartins JoaoCxMartins is a code owner

@EduardoSemanas EduardoSemanas Awaiting requested review from EduardoSemanas EduardoSemanas is a code owner

@cx-ruiaraujo cx-ruiaraujo Awaiting requested review from cx-ruiaraujo cx-ruiaraujo is a code owner

@asofsilva asofsilva Awaiting requested review from asofsilva asofsilva is a code owner

@cx-andrep cx-andrep Awaiting requested review from cx-andrep cx-andrep is a code owner

Assignees
No one assigned
Labels
bug Something isn't working query New query feature terraform Terraform query
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ArturRibeiro-CX @gabriel-cx @cx-andrep