Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove (unused) debug method in SpendBundle so we can decouple from chia.wallet.util #17839

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

AmineKhaldi
Copy link
Contributor

No description provided.

@AmineKhaldi AmineKhaldi added Changed Required label for PR that categorizes merge commit message as "Changed" for changelog Cleanup Code cleanup labels Apr 8, 2024
@AmineKhaldi AmineKhaldi self-assigned this Apr 8, 2024
@AmineKhaldi AmineKhaldi marked this pull request as ready for review April 8, 2024 17:47
@AmineKhaldi AmineKhaldi requested a review from a team as a code owner April 8, 2024 17:47
@arvidn
Copy link
Contributor

arvidn commented Apr 14, 2024

@Quexington expressed interest in keeping this to be able to print a spend bundle from the debugger.
I'm kind of hoping there is a better solution to this than to mix debugger functionality into the production code, but I'm not familiar enough with pdb to suggest something.

@Quexington
Copy link
Contributor

Yeah as Arvid said (and I've discussed with Amine offline), this function is very helpful when developing new chialisp and you run it alot so even requiring a separate import in pdb is quite a hassle if you have to type from chia.development.debug_spend_bundle import debug_spend_bundle all the time. I agree with the assertion that this should be separated out as much as possible though. Some alternatives I've suggested are: creating just such a module and patching it into the SpendBundle class at test runtime through conftest.py or perhaps creating a new SpendBundle version just in the wallet that subclasses the original and adds this method.

@AmineKhaldi AmineKhaldi marked this pull request as draft April 17, 2024 14:17
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the merge_conflict Branch has conflicts that prevent merge to main label Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog Cleanup Code cleanup merge_conflict Branch has conflicts that prevent merge to main
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants