Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore items in lists where the type is unknown #6467

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

A360JMaxxgamer
Copy link
Collaborator

Ignores all items when a list is deserialized where the GraphQL type is not part of the schema.graphql file.

  • Add TryParse method to IEntityIdSerliazer
  • Add check whether entity id can be parsed and whether the item shall be added to the list

Closes #6415

@A360JMaxxgamer
Copy link
Collaborator Author

@PascalSenn is it worth fixing the unit tests or is that as designed?

@michaelstaib
Copy link
Member

what is the status on this one?

@A360JMaxxgamer
Copy link
Collaborator Author

I changed the code to use try parse mechanism. If that solution is generally ok with you, I will fix the rest of the unittests. Basically update the snapshots.

@A360JMaxxgamer A360JMaxxgamer marked this pull request as ready for review August 25, 2023 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unknown interface types in result list throws exception
2 participants