Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress compiler warning in auto-generated code #6474

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

VaclavSir
Copy link

Disabling compiler warning CS1591 (missing XML comment) in the generated code.

Closes #5987

@CLAassistant
Copy link

CLAassistant commented Aug 24, 2023

CLA assistant check
All committers have signed the CLA.

@github-actions
Copy link

HotChocolate.Subscriptions.Postgres.BackgroundTaskTests.RunContinuously_Should_WaitForASecond_When_HandlerThrowsException [FAIL]

@github-actions
Copy link

HotChocolate.Execution.Integration.Spec.MutationTests.Ensure_Mutations_Are_Executed_Serially [FAIL]
HotChocolate.Execution.Integration.DataLoader.UseDataLoaderTests.UseDataLoader_Schema_BatchDataloader_Single_Execute [FAIL]
HotChocolate.Execution.Errors.ErrorBehaviorTests.AsyncMethod_Await_Return_ApplicationError [FAIL]
HotChocolate.Execution.Batching.BatchQueryExecutorTests.ExecuteExportScalarList_ExplicitVariable [FAIL]
HotChocolate.Execution.Integration.DataLoader.DataLoaderTests.FetchOnceDataLoader [FAIL]
HotChocolate.Execution.Integration.StarWarsCodeFirst.StarWarsCodeFirstTests.GraphQLOrgFragmentExample [FAIL]

@github-actions
Copy link

HotChocolate.Subscriptions.RabbitMQ.RabbitMQIntegrationTests.Subscribe_Topic_With_Arguments [FAIL]
HotChocolate.Subscriptions.RabbitMQ.RabbitMQIntegrationTests.Subscribe_Infer_Topic [FAIL]
HotChocolate.Subscriptions.RabbitMQ.RabbitMQIntegrationTests.Subscribe_And_Complete_Topic [FAIL]
HotChocolate.Subscriptions.RabbitMQ.RabbitMQIntegrationTests.Subscribe_Topic_With_2_Arguments [FAIL]
HotChocolate.Subscriptions.RabbitMQ.RabbitMQIntegrationTests.Subscribe_Static_Topic [FAIL]
HotChocolate.Subscriptions.RabbitMQ.RabbitMQIntegrationTests.Subscribe_Topic_With_Arguments_2_Topics [FAIL]
HotChocolate.Subscriptions.RabbitMQ.RabbitMQIntegrationTests.Subscribe_Topic_With_Arguments_2_Subscriber [FAIL]
HotChocolate.Subscriptions.RabbitMQ.RabbitMQIntegrationTests.Subscribe_And_Complete_Topic_With_ValueTypeMessage [FAIL]

@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3ed4025) 63.92% compared to head (3a97624) 63.45%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6474      +/-   ##
==========================================
- Coverage   63.92%   63.45%   -0.47%     
==========================================
  Files        2324     2324              
  Lines      114629   114629              
==========================================
- Hits        73275    72739     -536     
- Misses      41354    41890     +536     
Flag Coverage Δ
unittests 63.45% <ø> (-0.47%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link

HotChocolate.Subscriptions.Postgres.BackgroundTaskTests.RunContinuously_Should_WaitForASecond_When_HandlerThrowsException [FAIL]

@github-actions
Copy link

HotChocolate.Execution.Integration.StarWarsCodeFirst.StarWarsCodeFirstTests.Depth_Analysis_Overrides_Are_Not_Cached [FAIL]
HotChocolate.Execution.Integration.DataLoader.DataLoaderTests.ClassDataLoader_Resolve_From_DependencyInjection [FAIL]

@github-actions
Copy link

github-actions bot commented Sep 6, 2023

HotChocolate.Data.Spatial.Filters.QueryableFilterVisitorOverlapsTests.Create_Overlaps_Query [FAIL]
HotChocolate.Data.Spatial.Filters.QueryableFilterVisitorTouchesTests.Create_Touches_Query [FAIL]

@github-actions
Copy link

github-actions bot commented Sep 6, 2023

HotChocolate.Subscriptions.Postgres.BackgroundTaskTests.RunContinuously_Should_WaitForASecond_When_HandlerThrowsException [FAIL]

@github-actions
Copy link

github-actions bot commented Sep 6, 2023

HotChocolate.Execution.Integration.StarWarsCodeFirst.StarWarsCodeFirstTests.TypeNameFieldIsCorrectlyExecutedOnInterfaces [FAIL]

@github-actions
Copy link

github-actions bot commented Sep 7, 2023

HotChocolate.Diagnostics.QueryInstrumentationTests.Track_data_loader_events_with_keys [FAIL]

@github-actions
Copy link

github-actions bot commented Sep 7, 2023

HotChocolate.Data.Spatial.Filters.QueryableFilterVisitorDistanceTests.Create_Distance_Expression [FAIL]

@github-actions
Copy link

github-actions bot commented Sep 7, 2023

HotChocolate.Execution.Integration.Spec.MutationTests.Ensure_Mutations_Child_Fields_Are_Scoped_To_Its_Parent [FAIL]
HotChocolate.Execution.Integration.DataLoader.UseDataLoaderTests.UseDataLoader_Schema_GroupedDataloader_Single_Execute [FAIL]
HotChocolate.Execution.Integration.StarWarsCodeFirst.StarWarsCodeFirstTests.GraphQLOrgVariableWithDefaultValueExample [FAIL]

@github-actions
Copy link

github-actions bot commented Sep 7, 2023

HotChocolate.Subscriptions.Postgres.BackgroundTaskTests.RunContinuously_Should_WaitForASecond_When_HandlerThrowsException [FAIL]

@sonarcloud
Copy link

sonarcloud bot commented Sep 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@github-actions
Copy link

HotChocolate.Data.Spatial.Filters.QueryableFilterVisitorDistanceTests.Create_Distance_Expression [FAIL]

@github-actions
Copy link

HotChocolate.Execution.Integration.Spec.MutationTests.Ensure_Mutations_Child_Fields_Are_Scoped_To_Its_Parent [FAIL]

@github-actions
Copy link

github-actions bot commented Oct 3, 2023

HotChocolate.Subscriptions.Postgres.BackgroundTaskTests.RunContinuously_Should_WaitForASecond_When_HandlerThrowsException [FAIL]

@github-actions
Copy link

github-actions bot commented Oct 3, 2023

HotChocolate.Execution.Integration.StarWarsCodeFirst.StarWarsCodeFirstTests.GraphQLOrgVariableWithDefaultValueExample [FAIL]

@github-actions
Copy link

StrawberryShake.CodeGeneration.Mappers.ClientDescriptorMapperTests.MapClientDescriptor [FAIL]
StrawberryShake.CodeGeneration.Mappers.TypeDescriptorMapperTests.MapClientTypeDescriptors [FAIL]
StrawberryShake.CodeGeneration.Mappers.OperationDescriptorMapperTests.MapOperationTypeDescriptors [FAIL]
StrawberryShake.CodeGeneration.Analyzers.DocumentAnalyzerTests.One_Fragment_One_Deferred_Fragment [FAIL]
StrawberryShake.CodeGeneration.Analyzers.DocumentAnalyzerTests.One_Document_One_Op_One_Field_No_Fragments [FAIL]
StrawberryShake.CodeGeneration.Mappers.ResultBuilderDescriptorMapperTests.MapResultBuilderDescriptors [FAIL]
StrawberryShake.CodeGeneration.Mappers.EnumDescriptorMapperTests.MapEnumTypeDescriptors [FAIL]
StrawberryShake.CodeGeneration.Mappers.DataTypeMapperTests.MapDataTypeDescriptors_SimpleCase [FAIL]
StrawberryShake.CodeGeneration.Utilities.QueryDocumentRewriterTests.GetReturnTypeName [FAIL]

@github-actions
Copy link

HotChocolate.Data.Spatial.Filters.QueryableFilterVisitorDistanceTests.Create_Distance_Expression [FAIL]

@github-actions
Copy link

HotChocolate.Data.Neo4J.Filtering.Neo4JBooleanFilterTests.BooleanFilter_SchemaSnapshot [FAIL]
HotChocolate.Data.Neo4J.Filtering.Neo4JBooleanFilterTests.Nullable_BooleanFilter_SchemaSnapshot [FAIL]
HotChocolate.Data.Neo4J.Filtering.Neo4JFilterComparableTests.Create_Implicit_Operation [FAIL]
HotChocolate.Data.Neo4J.Filtering.Neo4JFilterComparableTests.Create_Implicit_Operation_Normalized [FAIL]

@github-actions
Copy link

HotChocolate.Data.Neo4JBooleanSortingTests.BooleanSorting_SchemaSnapshot [FAIL]
HotChocolate.Data.Neo4JComparableSortingTests.ComparableSorting_SchemaSnapshot [FAIL]
HotChocolate.Data.Neo4JStringsSortingTests.StringSorting_SchemaSnapshot [FAIL]

@github-actions
Copy link

HotChocolate.Data.Neo4JOffsetPagingTests.OffsetPaging_SchemaSnapshot [FAIL]

@github-actions
Copy link

StrawberryShake.CodeGeneration.CSharp.Integration.StarWarsIntrospection.StarWarsIntrospectionTest.Execute_StarWarsIntrospection_Test [FAIL]

@github-actions
Copy link

HotChocolate.Execution.Integration.Spec.MutationTests.Ensure_Mutations_Child_Fields_Are_Scoped_To_Its_Parent [FAIL]
HotChocolate.Execution.Integration.DataLoader.DataLoaderTests.FetchGroupDataLoader [FAIL]

Copy link

sonarcloud bot commented Dec 13, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@glen-84
Copy link
Collaborator

glen-84 commented Jan 14, 2024

This seems okay. The alternatives would be:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suppress warning CS1591: Missing XML comment in autogenerated code
4 participants