Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor CookieCrumble to abstract test frameworks #6537

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

stuartjbrown
Copy link

Refactor the test framework specific logic / code into their own assemblies in order to avoid polluting the CookieCrumble project with test framework specific references. This means that a small amount of (global) setup is needed before using Snapshot.

  • Added an interface ITestFramework to abstract the test framework specific logic
  • Added 2 projects with the test framework specific implementation (CookieCrumble.MSTest and CookieCrumble.Xunit)
  • Added a test project for MSTest and updated the existing one which uses Xunit

@stuartjbrown stuartjbrown changed the title Feat/refactor into test frameworks Refactor CookieCrumble to abstract test frameworks Sep 14, 2023
@github-actions
Copy link

HotChocolate.Data.Spatial.Filters.QueryableFilterVisitorIntersectsTests.Create_Intersects_Query [FAIL]

@github-actions
Copy link

HotChocolate.Execution.Integration.StarWarsCodeFirst.StarWarsCodeFirstTests.TypeNameFieldIsCorrectlyExecutedOnInterfaces [FAIL]

@github-actions
Copy link

[FAIL]

@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Patch coverage: 57.77% and project coverage change: -0.12% ⚠️

Comparison is base (6965960) 78.98% compared to head (a60783e) 78.87%.
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6537      +/-   ##
==========================================
- Coverage   78.98%   78.87%   -0.12%     
==========================================
  Files        2903     2917      +14     
  Lines      139771   140402     +631     
==========================================
+ Hits       110397   110740     +343     
- Misses      29374    29662     +288     
Flag Coverage Δ
unittests 78.87% <57.77%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...ocolate/Fusion/src/Core/Execution/Nodes/Resolve.cs 78.33% <12.50%> (-10.35%) ⬇️
...sion/src/Core/Execution/Nodes/ResolveByKeyBatch.cs 69.30% <12.50%> (-2.34%) ⬇️
...Types/Resolvers/DirectiveClassMiddlewareFactory.cs 62.50% <75.00%> (+44.31%) ⬆️
src/CookieCrumble/src/CookieCrumble/Snapshot.cs 77.74% <80.95%> (ø)
...rc/Core/Metadata/FusionGraphConfigurationReader.cs 94.04% <100.00%> (+0.90%) ⬆️

... and 41 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant