Skip to content

Commit

Permalink
[l10n] Lock some UI string terms and update descriptions.
Browse files Browse the repository at this point in the history
Bug: 1163928
Change-Id: Ied271629613b32f70e4dbb839a82707b228b1efb
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2703970
Commit-Queue: Peter Marshall <petermarshall@chromium.org>
Auto-Submit: Peter Marshall <petermarshall@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
  • Loading branch information
psmarshall authored and Commit Bot committed Feb 19, 2021
1 parent 426df43 commit 2c3fb30
Show file tree
Hide file tree
Showing 14 changed files with 63 additions and 49 deletions.
4 changes: 3 additions & 1 deletion front_end/accessibility/AccessibilityNodeView.ts
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,9 @@ export const UIStrings = {
*/
staticTextNodeIsUsed: 'Static text node is used as name for\xA0',
/**
*@description Reason element in Accessibility Node View of the Accessibility pane
* @description Reason element in Accessibility Node View of the Accessibility pane. Here
* 'interesting' is from the perspective of the accessibility engine in Chrome. A non-interesting
* element doesn't have any special accessibility considerations
*/
elementNotInteresting: 'Element not interesting for accessibility.',
};
Expand Down
16 changes: 9 additions & 7 deletions front_end/accessibility/AccessibilityStrings.ts
Original file line number Diff line number Diff line change
Expand Up @@ -414,15 +414,17 @@ export const UIStrings = {
/**
* @description Accessibility attribute name that appears under the Computed Properties section in
* the Accessibility pane of the Elements pane. Indicates that this element got assigned this
* attribute because there is a related label, hence it received it from the label. 'label
* (wrapped)' is part of the ARIA API and should not be translated. label (wrapped) is just a
* different type of label.
* attribute because there is a related label which wraps (encompasses, surrounds) this element,
* hence it received it from the label. 'wrapped' is not part of the ARIA API, and should be
* translated.
*/
fromLabelWrapped: 'From `label (wrapped)`',
fromLabelWrapped: 'From `label` (wrapped)',
/**
*@description Tooltip text that appears when hovering over the 'From label (wrapped)' attribute name under the Computed Properties section in the Accessibility pane of the Elements pane
* @description Tooltip text that appears when hovering over the 'From label (wrapped)' attribute
* name under the Computed Properties section in the Accessibility pane of the Elements pane.
* Indicates that there is a label element wrapping (surrounding) this element.
*/
valueFromLabelElementWrapped: 'Value from `label` element wrapped.',
valueFromLabelElementWrapped: 'Value from a wrapping `label` element.',
/**
* @description Accessibility attribute name that appears under the Computed Properties section in
* the Accessibility pane of the Elements pane. Indicates that this element got assigned this
Expand All @@ -433,7 +435,7 @@ export const UIStrings = {
/**
*@description Tooltip text that appears when hovering over the 'From legend' attribute name under the Computed Properties section in the Accessibility pane of the Elements pane
*/
valueFromLegendElement: 'Value from legend element.',
valueFromLegendElement: 'Value from `legend` element.',
/**
*@description Accessibility attribute name that appears under the Computed Properties section in the Accessibility pane of the Elements pane
*/
Expand Down
18 changes: 12 additions & 6 deletions front_end/browser_sdk/browser_sdk-meta.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,16 +16,22 @@ export const UIStrings = {
*/
preserveLog: 'Preserve log',
/**
*@description A tag of Network preserve log settings that can be searched in the command menu
*/
* @description A term that can be used to search in the command menu, and will find the search
* result 'Preserve log on page reload / navigation'. This is an additional search term to help
* user find the setting even when they don't know the exact name of it.
*/
preserve: 'preserve',
/**
*@description A tag of Network preserve log settings that can be searched in the command menu
*/
* @description A term that can be used to search in the command menu, and will find the search
* result 'Preserve log on page reload / navigation'. This is an additional search term to help
* user find the setting even when they don't know the exact name of it.
*/
clear: 'clear',
/**
*@description A tag of Network preserve log settings that can be searched in the command menu
*/
* @description A term that can be used to search in the command menu, and will find the search
* result 'Preserve log on page reload / navigation'. This is an additional search term to help
* user find the setting even when they don't know the exact name of it.
*/
reset: 'reset',
/**
*@description Title of a setting under the Network category that can be invoked through the Command Menu
Expand Down
4 changes: 2 additions & 2 deletions front_end/i18n/locales/en-US.json
Original file line number Diff line number Diff line change
Expand Up @@ -318,7 +318,7 @@
"message": "Value from label element with for= attribute."
},
"accessibility/AccessibilityStrings.ts | valueFromLabelElementWrapped": {
"message": "Value from label element wrapped."
"message": "Value from a wrapping label element."
},
"accessibility/AccessibilityStrings.ts | valueFromLegendElement": {
"message": "Value from legend element."
Expand Down Expand Up @@ -5814,7 +5814,7 @@
"message": "Name"
},
"resources/AppManifestView.js | needHelpReadOurS": {
"message": "Need help? Read our {PH1}."
"message": "Need help? Read {PH1}."
},
"resources/AppManifestView.js | noManifestDetected": {
"message": "No manifest detected"
Expand Down
26 changes: 13 additions & 13 deletions front_end/i18n/locales/en-XL.json
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@
"message": "F̂ŕôḿ label (for)"
},
"accessibility/AccessibilityStrings.ts | fromLabelWrapped": {
"message": "F̂ŕôḿ label (wrapped)"
"message": "F̂ŕôḿ label (ŵŕâṕp̂éd̂)"
},
"accessibility/AccessibilityStrings.ts | fromLegend": {
"message": "F̂ŕôḿ legend"
Expand Down Expand Up @@ -318,10 +318,10 @@
"message": "V̂ál̂úê f́r̂óm̂ label él̂ém̂én̂t́ ŵít̂h́ for= ât́t̂ŕîb́ût́ê."
},
"accessibility/AccessibilityStrings.ts | valueFromLabelElementWrapped": {
"message": "V̂ál̂úê f́r̂óm̂ label él̂ém̂én̂t́ ŵŕâṕp̂éd̂."
"message": "V̂ál̂úê f́r̂óm̂ á ŵŕâṕp̂ín̂ǵ label êĺêḿêńt̂."
},
"accessibility/AccessibilityStrings.ts | valueFromLegendElement": {
"message": "V̂ál̂úê f́r̂óm̂ ĺêǵêńd̂ él̂ém̂én̂t́."
"message": "V̂ál̂úê f́r̂óm̂ legend él̂ém̂én̂t́."
},
"accessibility/AccessibilityStrings.ts | valueFromNativeHtmlRuby": {
"message": "V̂ál̂úê f́r̂óm̂ ńât́îv́ê H́T̂ḾL̂ ŕûb́ŷ án̂ńôt́ât́îón̂."
Expand Down Expand Up @@ -2997,7 +2997,7 @@
"message": "B̂íĝ Én̂d́îán̂"
},
"linear_memory_inspector/ValueInterpreterDisplayUtils.ts | dec": {
"message": "d̂éĉ"
"message": "dec"
},
"linear_memory_inspector/ValueInterpreterDisplayUtils.ts | float64Bit": {
"message": "F̂ĺôát̂ 64-b́ît́"
Expand All @@ -3006,7 +3006,7 @@
"message": "F̂ĺôát̂ 32-b́ît́"
},
"linear_memory_inspector/ValueInterpreterDisplayUtils.ts | hex": {
"message": "ĥéx̂"
"message": "hex"
},
"linear_memory_inspector/ValueInterpreterDisplayUtils.ts | integer16Bit": {
"message": "Îńt̂éĝér̂ 16-b́ît́"
Expand All @@ -3024,10 +3024,10 @@
"message": "L̂ít̂t́l̂é Êńd̂íâń"
},
"linear_memory_inspector/ValueInterpreterDisplayUtils.ts | oct": {
"message": "ôćt̂"
"message": "oct"
},
"linear_memory_inspector/ValueInterpreterDisplayUtils.ts | sci": {
"message": "ŝćî"
"message": "sci"
},
"linear_memory_inspector/ValueInterpreterDisplayUtils.ts | string": {
"message": "Ŝt́r̂ín̂ǵ"
Expand Down Expand Up @@ -3666,7 +3666,7 @@
"message": "ŝíĝńêd́-êx́ĉh́âńĝé"
},
"network/NetworkDataGridNode.js | signedexchangeq": {
"message": "(ŝíĝńêd́-êx́ĉh́âńĝé)"
"message": "(signed-exchange)"
},
"network/NetworkDataGridNode.js | sPreflight": {
"message": "{PH1} + P̂ŕêf́l̂íĝh́t̂"
Expand Down Expand Up @@ -4131,10 +4131,10 @@
"message": "T̂h́îś r̂éq̂úêśt̂ h́âś n̂ó ĉóôḱîéŝ."
},
"network/RequestHeadersView.js | activeClientExperimentVariation": {
"message": "Âćt̂ív̂é ĉĺîén̂t́ êx́p̂ér̂ím̂én̂t́ v̂ár̂íât́îón̂ ÍD̂ś."
"message": "Âćt̂ív̂é client experiment variation IDs."
},
"network/RequestHeadersView.js | activeClientExperimentVariationIds": {
"message": "Âćt̂ív̂é ĉĺîén̂t́ êx́p̂ér̂ím̂én̂t́ v̂ár̂íât́îón̂ ÍD̂ś t̂h́ât́ t̂ŕîǵĝér̂ śêŕv̂ér̂-śîd́ê b́êh́âv́îór̂."
"message": "Âćt̂ív̂é client experiment variation IDs t̂h́ât́ t̂ŕîǵĝér̂ śêŕv̂ér̂-śîd́ê b́êh́âv́îór̂."
},
"network/RequestHeadersView.js | chooseThisOptionIfTheResourceAnd": {
"message": "Ĉh́ôóŝé t̂h́îś ôṕt̂íôń îf́ t̂h́ê ŕêśôúr̂ćê án̂d́ t̂h́ê d́ôćûḿêńt̂ ár̂é ŝér̂v́êd́ f̂ŕôḿ t̂h́ê śâḿê śît́ê."
Expand Down Expand Up @@ -5814,7 +5814,7 @@
"message": "N̂ám̂é"
},
"resources/AppManifestView.js | needHelpReadOurS": {
"message": "N̂éêd́ ĥél̂ṕ? R̂éâd́ ôúr̂ {PH1}."
"message": "N̂éêd́ ĥél̂ṕ? R̂éâd́ {PH1}."
},
"resources/AppManifestView.js | noManifestDetected": {
"message": "N̂ó m̂án̂íf̂éŝt́ d̂ét̂éĉt́êd́"
Expand Down Expand Up @@ -6351,7 +6351,7 @@
"message": "Content-Length"
},
"resources/ServiceWorkerCacheViews.js | contenttype": {
"message": "Ĉón̂t́êńt̂-T́ŷṕê"
"message": "Content-Type"
},
"resources/ServiceWorkerCacheViews.js | deleteSelected": {
"message": "D̂él̂ét̂é Ŝél̂éĉt́êd́"
Expand All @@ -6375,7 +6375,7 @@
"message": "R̂éf̂ŕêśĥ"
},
"resources/ServiceWorkerCacheViews.js | responsetype": {
"message": "R̂éŝṕôńŝé-T̂ýp̂é"
"message": "Response-Type"
},
"resources/ServiceWorkerCacheViews.js | selectACacheEntryAboveToPreview": {
"message": "Ŝél̂éĉt́ â ćâćĥé êńt̂ŕŷ áb̂óv̂é t̂ó p̂ŕêv́îéŵ"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,19 +9,19 @@ export const UIStrings = {
/**
*@description Text that describes the representation of a value in the Linear Memory Inspector, short for decimal
*/
dec: 'dec',
dec: '`dec`',
/**
*@description Text that describes the representation of a value in the Linear Memory Inspector
*@description Text that describes the representation of a value in the Linear Memory Inspector, short for hexadecimal
*/
hex: 'hex',
hex: '`hex`',
/**
*@description Text that describes the representation of a value in the Linear Memory Inspector, short for octal
*/
oct: 'oct',
oct: '`oct`',
/**
*@description Text that describes the representation of a value in the Linear Memory Inspector, short for scientific
*/
sci: 'sci',
sci: '`sci`',
/**
*@description Text that describes the Endianness setting that can be selected in the select item in the Linear Memory Inspector
*/
Expand Down
2 changes: 1 addition & 1 deletion front_end/network/NetworkDataGridNode.js
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@ export const UIStrings = {
/**
*@description Text of a DOM element in Network Data Grid Node of the Network panel
*/
signedexchangeq: '(signed-exchange)',
signedexchangeq: '`(signed-exchange)`',
/**
*@description Cell title in Network Data Grid Node of the Network panel
*@example {4 B} PH1
Expand Down
8 changes: 5 additions & 3 deletions front_end/network/NetworkLogView.js
Original file line number Diff line number Diff line change
Expand Up @@ -128,9 +128,11 @@ export const UIStrings = {
*/
sBSBTransferredOverNetwork: '{PH1} B / {PH2} B transferred over network',
/**
*@description Text in Network Log View of the Network panel
*@example {40MB} PH1
*@example {50MB} PH2
* @description Text in Network Log View of the Network panel. Appears when a particular network
* resource is selected by the user. Shows how large the selected resource was (PH1) out of the
* total size (PH2).
* @example {40MB} PH1
* @example {50MB} PH2
*/
sSResources: '{PH1} / {PH2} resources',
/**
Expand Down
4 changes: 2 additions & 2 deletions front_end/network/NetworkTimeCalculator.js
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,8 @@ export const UIStrings = {
*/
sLatency: '{PH1} latency',
/**
*@description Download format in Network Time Calculator of the Network panel
*@example {5} PH1
* @description Duration of the download in ms/s shown for a completed network request.
* @example {5ms} PH1
*/
sDownload: '{PH1} download',
/**
Expand Down
4 changes: 2 additions & 2 deletions front_end/network/RequestHeadersView.js
Original file line number Diff line number Diff line change
Expand Up @@ -168,11 +168,11 @@ export const UIStrings = {
/**
*@description Comment used in decoded X-Client-Data HTTP header output in Headers View of the Network panel
*/
activeClientExperimentVariation: 'Active client experiment variation IDs.',
activeClientExperimentVariation: 'Active `client experiment variation IDs`.',
/**
*@description Comment used in decoded X-Client-Data HTTP header output in Headers View of the Network panel
*/
activeClientExperimentVariationIds: 'Active client experiment variation IDs that trigger server-side behavior.',
activeClientExperimentVariationIds: 'Active `client experiment variation IDs` that trigger server-side behavior.',
/**
*@description Text in Headers View of the Network panel for X-Client-Data HTTP headers
*/
Expand Down
4 changes: 2 additions & 2 deletions front_end/resources/AppManifestView.js
Original file line number Diff line number Diff line change
Expand Up @@ -87,9 +87,9 @@ export const UIStrings = {
documentationOnMaskableIcons: 'documentation on maskable icons',
/**
*@description Text wrapping a link pointing to more information on maskable icons in App Manifest view of the Application panel
*@example {https://example.com/} PH1
*@example {https://web.dev/maskable-icon/} PH1
*/
needHelpReadOurS: 'Need help? Read our {PH1}.',
needHelpReadOurS: 'Need help? Read {PH1}.',
/**
*@description Label for the primary icon loaded from the manifest
*@example {https://example.com/} PH1
Expand Down
4 changes: 2 additions & 2 deletions front_end/resources/ServiceWorkerCacheViews.js
Original file line number Diff line number Diff line change
Expand Up @@ -38,11 +38,11 @@ export const UIStrings = {
/**
*@description Text in Service Worker Cache Views of the Application panel
*/
responsetype: 'Response-Type',
responsetype: '`Response-Type`',
/**
*@description Text in Service Worker Cache Views of the Application panel
*/
contenttype: 'Content-Type',
contenttype: '`Content-Type`',
/**
*@description Text for the network request Content-Length header
*/
Expand Down
5 changes: 3 additions & 2 deletions front_end/resources/ServiceWorkersView.js
Original file line number Diff line number Diff line change
Expand Up @@ -106,8 +106,9 @@ export const UIStrings = {
*/
sRegistrationErrors: '{PH1} registration errors',
/**
*@description Text in Service Workers View of the Application panel
*@example {7/3/2019, 3:38:37 PM} PH1
* @description Text in Service Workers View of the Application panel. The Date/time that a service
* worker version update was received by the webpage.
* @example {7/3/2019, 3:38:37 PM} PH1
*/
receivedS: 'Received {PH1}',
/**
Expand Down
3 changes: 2 additions & 1 deletion front_end/timeline_model/TimelineIRModel.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,8 @@ import {RecordType} from './TimelineModel.js';

export const UIStrings = {
/**
*@description Text in Timeline IRModel of the Performance panel
* @description Error text in Timeline IRModel of the Performance panel. Indicates that two fling
* gestures were detected at the same time, which should not be possible.
*@example {2s} PH1
*@example {3s} PH2
*/
Expand Down

0 comments on commit 2c3fb30

Please sign in to comment.