Migrate front_end/inline_editor to devtools_entrypoint

R=aerotwist@chromium.org, jacktfranklin@chromium.org

Bug: 1101738
Change-Id: Iaae55e2a78c212b2bb6d5f4d66a8106466cc6d07
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2323637
Commit-Queue: Jan Scheffler <janscheffler@chromium.org>
Auto-Submit: Jan Scheffler <janscheffler@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>

all_devtools_modules.gni

@@ -56,12 +56,6 @@ all_devtools_module_sources = [
   "help/HelpImpl.js",
   "help/ReleaseNoteText.js",
   "help/ReleaseNoteView.js",
-  "inline_editor/BezierEditor.js",
-  "inline_editor/BezierUI.js",
-  "inline_editor/CSSShadowEditor.js",
-  "inline_editor/CSSShadowModel.js",
-  "inline_editor/ColorSwatch.js",
-  "inline_editor/SwatchPopoverHelper.js",
   "input/InputModel.js",
   "input/InputTimeline.js",
   "inspector_main/InspectorMain.js",
@@ -435,6 +429,12 @@ all_typescript_module_sources = [
   "host/Platform.js",
   "host/ResourceLoader.js",
   "host/UserMetrics.js",
+  "inline_editor/BezierEditor.js",
+  "inline_editor/BezierUI.js",
+  "inline_editor/CSSShadowEditor.js",
+  "inline_editor/CSSShadowModel.js",
+  "inline_editor/ColorSwatch.js",
+  "inline_editor/SwatchPopoverHelper.js",
   "issues/IssueAggregator.js",
   "issues/IssueRevealer.js",
   "issues/IssuesPane.js",

devtools_module_entrypoints.gni

@@ -46,7 +46,6 @@ devtools_module_entrypoint_sources = [
   "help/help.js",
   "host/host-legacy.js",
   "inline_editor/inline_editor-legacy.js",
-  "inline_editor/inline_editor.js",
   "input/input-legacy.js",
   "input/input.js",
   "inspector_main/inspector_main-legacy.js",
@@ -150,6 +149,7 @@ generated_typescript_entrypoint_sources = [
   "$resources_out_dir/har_importer/har_importer.js",
   "$resources_out_dir/heap_snapshot_model/heap_snapshot_model.js",
   "$resources_out_dir/host/host.js",
+  "$resources_out_dir/inline_editor/inline_editor.js",
   "$resources_out_dir/issues/issues.js",
   "$resources_out_dir/javascript_metadata/javascript_metadata.js",
   "$resources_out_dir/js_main/js_main.js",

front_end/BUILD.gn

@@ -30,6 +30,7 @@ group("front_end") {
     "har_importer:bundle",
     "heap_snapshot_model:bundle",
     "i18n:bundle_i18n",
+    "inline_editor:bundle",
     "issues:bundle",
     "javascript_metadata:bundle",
     "js_main:bundle",

front_end/inline_editor/BUILD.gn

@@ -2,10 +2,30 @@
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
-import("../../third_party/typescript/typescript.gni")
+import("../../scripts/build/ninja/devtools_entrypoint.gni")
+import("../../scripts/build/ninja/devtools_module.gni")
 
-ts_library("inline_editor") {
-  sources = [ "BezierUI.js" ]
+devtools_module("inline_editor") {
+  sources = [
+    "BezierEditor.js",
+    "BezierUI.js",
+    "CSSShadowEditor.js",
+    "CSSShadowModel.js",
+    "ColorSwatch.js",
+    "SwatchPopoverHelper.js",
+  ]
 
-  deps = [ "../ui:bundle" ]
+  deps = [
+    "../common:bundle",
+    "../platform:bundle",
+    "../text_utils:bundle",
+    "../ui:bundle",
+  ]
+}
+
+devtools_entrypoint("bundle") {
+  entrypoint = "inline_editor.js"
+  is_legacy_javascript_entrypoint = [ "crbug.com/1011811" ]
+
+  deps = [ ":inline_editor" ]
 }

front_end/inline_editor/BezierEditor.js

@@ -2,6 +2,9 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+// @ts-nocheck
+// TODO(crbug.com/1011811): Enable TypeScript compiler checks
+
 import * as Common from '../common/common.js';
 import * as Platform from '../platform/platform.js';
 import * as UI from '../ui/ui.js';

front_end/inline_editor/CSSShadowEditor.js

@@ -2,6 +2,9 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+// @ts-nocheck
+// TODO(crbug.com/1011811): Enable TypeScript compiler checks
+
 import * as Common from '../common/common.js';
 import * as Platform from '../platform/platform.js';
 import * as UI from '../ui/ui.js';

front_end/inline_editor/CSSShadowModel.js

@@ -2,6 +2,9 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+// @ts-nocheck
+// TODO(crbug.com/1011811): Enable TypeScript compiler checks
+
 import * as Common from '../common/common.js';
 import * as TextUtils from '../text_utils/text_utils.js';
 

front_end/inline_editor/ColorSwatch.js

@@ -2,6 +2,9 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+// @ts-nocheck
+// TODO(crbug.com/1011811): Enable TypeScript compiler checks
+
 import * as Common from '../common/common.js';
 import * as TextUtils from '../text_utils/text_utils.js';
 import * as UI from '../ui/ui.js';

front_end/inline_editor/SwatchPopoverHelper.js

@@ -2,6 +2,9 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+// @ts-nocheck
+// TODO(crbug.com/1011811): Enable TypeScript compiler checks
+
 import * as Common from '../common/common.js';
 import * as UI from '../ui/ui.js';
 

front_end/inline_editor/module.json

@@ -19,5 +19,6 @@
     "cssShadowSwatch.css",
     "cssShadowEditor.css",
     "swatchPopover.css"
-  ]
-}
+  ],
+  "skip_rollup": true
+}

test/unittests/front_end/inline_editor/BUILD.gn

@@ -5,7 +5,7 @@ ts_library("inline_editor") {
   sources = [ "BezierUI_test.ts" ]
 
   deps = [
-    "../../../../front_end/inline_editor",
+    "../../../../front_end/inline_editor:bundle",
     "../../../../front_end/ui:bundle",
   ]
 }