Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow extension by adding additional protocol files #301

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

pipobscure
Copy link

No description provided.

@google-cla
Copy link

google-cla bot commented Jul 31, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@paulirish
Copy link
Member

... but why?

@pipobscure
Copy link
Author

Sorry for the slow reply, I had to get all my CLA ducks into a row first.

The motivation for this is that we have a proxy that implements CDP and forwards much of the protocol to a number of chromium instances backing it. However it also has a few commands geared toward managing the environment.

Adding this makes it easy to simply specify the additional commands by adding a single untacked file to the repository contents and means we don't actually have to change anything to render the relevant type definitions out. Given that it also doesn't actually make a difference otherwise, I figured this would be something we could upstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants