Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(LH-72600): CodeQL scan less files than expected #100

Merged
merged 9 commits into from
Nov 6, 2023

Conversation

weilueluo
Copy link
Collaborator

@weilueluo weilueluo commented Nov 3, 2023

https://jira-eng-rtp3.cisco.com/jira/browse/LH-72600

Description

Run CodeQL separately for client and provider package, as codeql does not resolve local client package properly.

This is not a ultimate fix because CodeQL now fails to check for problems related to provider misusing the client package.

see also: github/codeql-action#1980

Copy link
Collaborator

@talhazi talhazi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@weilueluo weilueluo merged commit e2e6fde into main Nov 6, 2023
10 checks passed
@weilueluo weilueluo deleted the LH-72600-fix-codeql-scan-less-files-than-expected branch November 6, 2023 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants