Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update GitHub CI to remove deprecated/unmaintained actions and commands #846

Merged
merged 11 commits into from Oct 20, 2022

Conversation

ClementTsang
Copy link
Owner

@ClementTsang ClementTsang commented Oct 20, 2022

Description

A description of the change and what it does. If relevant (such as any change that modifies the UI), please provide screenshots of the change:

See here (deprecated set-output) and here (Node 12 is deprecated) - this was causing a bunch of warnings/spam in CI/workflows.

The updated CI changes are as follows:

  • Use macos-12 rather than macos-latest (which pointed to 11, and was warning that it was going to move to 12)
  • Use Swatinem/rust-cache pinned to 22c9328bcba27aa81a32b1bef27c7e3c78052531 (version 2.0.1)
  • Use dtolnay/rust-toolchain pinned to ba37adf8f94a7d9affce79bd3baff1b9e3189c33
  • Use crazy-max/ghaction-chocolatey pinned to 90deb87d9fbf0bb2f022b91e3bf11b4441cddda5 (version 2.1.0)
  • Use fkirc/skip-duplicate-actions pinned to f11521568414503656a5af807dc3018c012552c4 (version 5.2.0)
  • Use ClementTsang/cargo-action version 0.0.3
  • Use actions/upload-artifact pinned to 3cea5372237819ed00197afe530f5a7ea3e805c8 (version 3.1.0)
  • Use rustsec/audit-check pinned to bb800784d9c5b0afa352b75dae201bf2e438960a over action-rs/audit-check, which is unmaintained.
  • Remove actions-rs/toolchain, which I was still using in some niche cases where it worked better, as it is unmaintained and will likely break at some point unless someone takes ownership or it gets forked. I've already stopped using it for 99% of my workflows at this point, so this is probably for the better.

Note some actions are out of my control and have not yet updated - tracking list:

This also removes the GitHub workflow for macOS ARM since that is now handled by Cirrus CI.

Issue

If applicable, what issue does this address?

Closes: #

Testing

If relevant, please state how this was tested. All changes must be tested to work:

All affected workflows should be tested. This is primarily:

  • CI pipelines (required to pass PR anyways)
  • Audit (note it will fail as there is a current issue that will be addressed)
  • Nightly

Checklist

If relevant, ensure the following have been met:

  • Areas your change affects have been linted using rustfmt (cargo fmt)
  • The change has been tested and doesn't appear to cause any unintended breakage
  • Documentation has been added/updated if needed (README.md, help menu, etc.)
  • The pull request passes the provided CI pipeline
  • There are no merge conflicts
  • If relevant, new tests were added (don't worry too much about coverage)

@codecov-commenter
Copy link

codecov-commenter commented Oct 20, 2022

Codecov Report

Base: 18.81% // Head: 18.81% // No change to project coverage 👍

Coverage data is based on head (cd8947f) compared to base (8043a72).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #846   +/-   ##
=======================================
  Coverage   18.81%   18.81%           
=======================================
  Files          74       74           
  Lines       13504    13504           
=======================================
  Hits         2541     2541           
  Misses      10963    10963           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ClementTsang ClementTsang force-pushed the update_outdated_ci_cmds branch 3 times, most recently from 8711146 to 2543972 Compare October 20, 2022 10:01
@ClementTsang ClementTsang changed the title ci: update GitHub CI to remove deprecated commands ci: update GitHub CI to remove deprecated/unmaintained actions and commands Oct 20, 2022
@ClementTsang ClementTsang marked this pull request as ready for review October 20, 2022 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants