refactor(cc-addon-admin)!: rework properties to avoid impossible states #1044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florian-sanders-cc
force-pushed
the
cc-addon-admin/state-migration
branch
from
491be83
to
e68f177
Compare
|
🔎 A preview has been automatically published : https://clever-components-preview.cellar-c2.services.clever-cloud.com/cc-addon-admin/state-migration/index.html. This preview will be deleted once this PR is closed. |
florian-sanders-cc
force-pushed
the
cc-addon-admin/state-migration
branch
3 times, most recently
from
fb95c39
to
2bde9af
Compare
florian-sanders-cc
requested review from
Galimede,
hsablonniere and
roberttran-cc
and removed request for
Galimede
florian-sanders-cc
force-pushed
the
cc-addon-admin/state-migration
branch
2 times, most recently
from
b6a99dd
to
ad70a26
Compare
hsablonniere
requested changes
May 22, 2024
There was a problem hiding this comment.
Hey @florian-sanders-cc and @HeleneAmouzou, thank you for this 🎉
I added a few comments. I wanted to suggest to inline the subrender method but looking at its size and the number of variables it computes, I guess the current code is better.
Well done!
roberttran-cc
approved these changes
May 28, 2024
florian-sanders-cc
force-pushed
the
cc-addon-admin/state-migration
branch
3 times, most recently
from
2d323d0
to
6695d8d
Compare
BREAKING CHANGE: the properties have changed - `state`: new property containing the whole state - `addon`: property has been deleted as it is now part of the state - `error`: property has been deleted as it is now part of the state - `saving`: property has been deleted as it is now part of the state
florian-sanders-cc
force-pushed
the
cc-addon-admin/state-migration
branch
from
6110b3a
to
d6bea0b
Compare
hsablonniere
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
cc-addon-admincomponent to implement our new state structure,cc-addon-admincomponent and its stories,How to review?