-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(cc-addon-backups)!: rework properties to avoid impossible states #1049
base: master
Are you sure you want to change the base?
Conversation
🔎 A preview has been automatically published : https://clever-components-preview.cellar-c2.services.clever-cloud.com/cc-addon-backups/state-migration/index.html. This preview will be deleted once this PR is closed. |
1518700
to
99cd481
Compare
99cd481
to
5361b01
Compare
83e6650
to
840eaeb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @florian-sanders-cc and @HeleneAmouzou, thank you for this 🎉
I forgot how complex this component was with the overlays. I'm looking forward to our modal/dialog support even if it would reduce the code by half.
@cc-button:click=${ | ||
/** @param {CcButtonClickEvent} e */ | ||
(e) => this._onOpenOverlay(e, 'delete', backup) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note: this kind of JSDoc is a bit verbose to my taste but maybe it's just me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hsablonniere we agree with you but we have no alternative solution for this 🤷
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple non-blocking feedback: GG for this PR!
840eaeb
to
0d6495b
Compare
618f8d9
to
38871e7
Compare
005c6e3
to
4da4a3e
Compare
4da4a3e
to
6e7cc8e
Compare
…ates BREAKING CHANGE: the properties have changed - `state`: new property containing the whole state - `backups`: property has been deleted as it is now part of the state - `error`: property has been deleted as it is now part of the state
e89afe0
to
dc8377e
Compare
What does this PR do?
cc-addon-backups
component to implement our new state structure,cc-addon-backups
component and its stories,How to review?