-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(cc-elasticsearch-info)!: rework properties to avoid impossible states #1052
base: master
Are you sure you want to change the base?
Conversation
🔎 A preview has been automatically published : https://clever-components-preview.cellar-c2.services.clever-cloud.com/cc-elasticsearch-info/state-migration/index.html. This preview will be deleted once this PR is closed. |
f07bf3a
to
0d1d435
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @florian-sanders-cc and @HeleneAmouzou, thank you for this 🎉
I added one comment, feel free to apply it or not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this, LGTM! 💪 🎉
…le states BREAKING CHANGE: the properties have changed - `state`: new property containing the whole state - `error`: property has been deleted as it is now part of the state - `links`: property has been deleted as it is now part of the state
bddf517
to
c49c99c
Compare
What does this PR do?
cc-elasticsearch-info
component to implement our new state structure,cc-elasticsearch-info
component and its stories.How to review?