refactor(cc-matomo-info)!: rework properties to avoid impossible states #1055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🔎 A preview has been automatically published : https://clever-components-preview.cellar-c2.services.clever-cloud.com/cc-matomo-info/state-migration/index.html. This preview will be deleted once this PR is closed. |
florian-sanders-cc
force-pushed
the
cc-matomo-info/state-migration
branch
from
9739b32
to
8cbb237
Compare
pdesoyres-cc
requested changes
May 13, 2024
florian-sanders-cc
force-pushed
the
cc-matomo-info/state-migration
branch
2 times, most recently
from
1a8b1eb
to
3bccb7f
Compare
florian-sanders-cc
requested review from
Galimede and
roberttran-cc
and removed request for
Galimede
florian-sanders-cc
force-pushed
the
cc-matomo-info/state-migration
branch
2 times, most recently
from
91f9dd1
to
b63a8da
Compare
roberttran-cc
approved these changes
May 23, 2024
florian-sanders-cc
force-pushed
the
cc-matomo-info/state-migration
branch
from
7bd0de8
to
e62cfff
Compare
BREAKING CHANGE: the properties have changed - `state`: new property containing the whole state - `matomoLink`: property has been deleted as it is now part of the state as `matomoUrl` - `mysqlLink`: property has been deleted as it is now part of the state as `mysqlUrl` - `phpLink`: property has been deleted as it is now part of the state as `phpUrl` - `redisLink`: property has been deleted as it is now part of the state as `redisUrl` - `error`: property has been deleted as it is now part of the state
florian-sanders-cc
force-pushed
the
cc-matomo-info/state-migration
branch
from
9a100db
to
87b43de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
cc-matomo-infocomponent to implement our new state structure,cc-matomo-infocomponent and its stories.How to review?