Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display multi-line json error messages with github action #46353

Merged
merged 3 commits into from
Jan 2, 2021

Conversation

Qrox
Copy link
Contributor

@Qrox Qrox commented Dec 27, 2020

Summary

SUMMARY: Infrastructure "Display multi-line json error messages with github action"

Purpose of change

Currently only the first line of an json error message is displayed by the github problem matcher.

This PR fixes it by directly outputing error message commands in github action's command format, bypassing the problem matcher.

Describe the solution

Use the solution at stefanbuck/jest-matcher#2 to display multi-line messages with github action.

Currently only supports JSON errors.

Testing

image

@Qrox Qrox force-pushed the multiline branch 4 times, most recently from adb5587 to 102377f Compare December 28, 2020 06:17
@anothersimulacrum anothersimulacrum added Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style Code: Tests Measurement, self-control, statistics, balancing. labels Dec 28, 2020
@Qrox Qrox force-pushed the multiline branch 6 times, most recently from 8d3038b to 9b64388 Compare December 31, 2020 06:35
@Qrox Qrox changed the title Try to display multi-line messages with github problem matcher Display multi-line json error messages with github action Dec 31, 2020
@Qrox Qrox marked this pull request as ready for review December 31, 2020 07:03
@Qrox
Copy link
Contributor Author

Qrox commented Dec 31, 2020

It finally works. Turns out github action can only recognize normalized paths in the error commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style Code: Tests Measurement, self-control, statistics, balancing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants