Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overhaul and Flesh Out Barry Isherwood's Rescue Mission, part 2 #73388

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

MNG-cataclysm
Copy link
Contributor

Summary

Content "Overhaul and flesh out Barry Isherwood's rescue mission, part 2."

Purpose of change

This is a co-development PR for #73264, intended to cover parts of the project that Erk and I couldn't fit in the first one.

Describe the solution

This isn't ready yet, as we're still working on part 1.

Describe alternatives you've considered

N/A

Testing

N/A

Additional context

A design document can be found here

@github-actions github-actions bot added NPC / Factions NPCs, AI, Speech, Factions, Ownership [JSON] Changes (can be) made in JSON labels Apr 29, 2024
@MNG-cataclysm MNG-cataclysm changed the title S[WIP] Overhaul and Flesh Out Barry Isherwood's Rescue Mission, part 2 [WIP] Overhaul and Flesh Out Barry Isherwood's Rescue Mission, part 2 Apr 29, 2024
@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Apr 29, 2024
@github-actions github-actions bot added the Missions Quests and missions label May 4, 2024
@MNG-cataclysm
Copy link
Contributor Author

All that's left for this PR is to add some fail states to the rescue mission, but I don't think that can be reliably done until part 1 is merged.

@github-actions github-actions bot added Vehicles Vehicles, parts, mechanics & interactions Spawn Creatures, items, vehicles, locations appearing on map labels May 6, 2024
@github-actions github-actions bot added EOC: Effects On Condition Anything concerning Effects On Condition and removed BasicBuildPassed This PR builds correctly, label assigned by github actions labels May 20, 2024
@MNG-cataclysm MNG-cataclysm marked this pull request as ready for review May 22, 2024 02:05
@MNG-cataclysm MNG-cataclysm changed the title [WIP] Overhaul and Flesh Out Barry Isherwood's Rescue Mission, part 2 Overhaul and Flesh Out Barry Isherwood's Rescue Mission, part 2 May 22, 2024
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label May 22, 2024
@TealcOneill
Copy link
Contributor

TealcOneill commented May 26, 2024

Is this finished? It looks good 👍

@MNG-cataclysm
Copy link
Contributor Author

Is this finished? It looks good 👍

No, I'm still waiting for @I-am-Erk to finish the dialogue.

Co-authored-by: Maleclypse <54345792+Maleclypse@users.noreply.github.com>
Copy link
Contributor

github-actions bot commented Jun 2, 2024

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • If'n you survive, We can give you a fortnight and six odd days to pay us'n back.
  • [ayo I aint got that cash can I buy on credit?]
  • [i'm here to pay my riot gear off.]
  • [okie dokie i got an idea 4 how we can do this. theres 2 bandits who got a shitmobile, good enough to blow up i need u to go kill em. i'll pick it up later]
  • [okie now we need explosives. i know mines have a lot of dynamite so that should be good. go get it and i'll rig that up to a kitchen timer and we'll have a bomb on wheels. i need 50lbs]
  • [trust me bro i know what im doing]

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

Hints for adding a new word to the dictionary
  • If the word is normally in all lowercase, such as the noun word or the verb does, add it in its lower-case form; if the word is a proper noun, such as the surname George, add it in its initial-caps form; if the word is an acronym or has special letter case, such as the acronym CDDA or the unit mW, add it by preserving the case of all the letters. A word in the dictionary will also match its initial-caps form (if the word is in all lowercase) and all-uppercase form, so a word should be added to the dictionary in its normal letter case even if used in a different letter case in a sentence.
  • For a word to be added to the dictionary, it should either be a real, properly-spelled modern American English word, a foreign loan word (including romanized foreign names), or a foreign or made-up word that is used consistently and commonly enough in the game. Intentional misspelling (including eye dialect) of a word should not be added unless it has become a common terminology in the game, because while someone may have a legitimate use for it, another person may spell it that way accidentally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions EOC: Effects On Condition Anything concerning Effects On Condition [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Missions Quests and missions NPC / Factions NPCs, AI, Speech, Factions, Ownership Spawn Creatures, items, vehicles, locations appearing on map Vehicles Vehicles, parts, mechanics & interactions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants