Enable truncate operation for object storage disks.

[MikhailBurdukov]

Changelog category (leave one):

• Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Enable truncate operation for object storage disks.

Documentation entry for user-facing changes

• Documentation is written (mandatory for new features)

Motivation

For scenario log family engines + object storage disk, truncateFile is required to cancel failed inserts.
Without these changes the table might stuck in intermediate state, when data already inserted into data file and object storage, but in sizes file not and in log a lot of entries like:

2024.04.15 11:57:32.846308 [ 1914145 ] {01c725ca-e2d7-49ee-944e-14322746cccd} <Error> DB::StorageStripeLog::StorageStripeLog(DiskPtr, const String &, const StorageID &, const ColumnsDescription &, const ConstraintsDescription &, const String &, bool, ContextMutablePtr): Code: 48. DB::Exception: Truncate operation is not implemented for disk of type S3. (NOT_IMPLEMENTED), Stack trace (when copying this message, always include the lines below):

0. DB::Exception::Exception(DB::Exception::MessageMasked&&, int, bool) @ 0x000000000c623797 in /usr/bin/clickhouse
1. DB::Exception::Exception<DB::DataSourceType>(int, FormatStringHelperImpl<std::type_identity<DB::DataSourceType>::type>, DB::DataSourceType&&) @ 0x00000000114d56e0 in /usr/bin/clickhouse
2. DB::IDisk::truncateFile(String const&, unsigned long) @ 0x00000000114d7090 in /usr/bin/clickhouse
3. DB::FileChecker::repair() @ 0x00000000126f8639 in /usr/bin/clickhouse
4. std::shared_ptr<DB::IStorage> std::__function::__policy_invoker<std::shared_ptr<DB::IStorage> (DB::StorageFactory::Arguments const&)>::__call_impl<std::__function::__default_alloc_func<DB::registerStorageStripeLog(DB::StorageFactory&)::$_0, std::shared_ptr<DB::IStorage> (DB::StorageFactory::Arguments const&)>>(std::__function::__policy_storage const*, DB::StorageFactory::Arguments const&) (.llvm.3394659020605242725) @ 0x0000000012969137 in /usr/bin/clickhouse
5. DB::StorageFactory::get(DB::ASTCreateQuery const&, String const&, std::shared_ptr<DB::Context>, std::shared_ptr<DB::Context>, DB::ColumnsDescription const&, DB::ConstraintsDescription const&, bool) const @ 0x0000000012667c1b in /usr/bin/clickhouse
6. DB::createTableFromAST(DB::ASTCreateQuery, String const&, String const&, std::shared_ptr<DB::Context>, bool) @ 0x000000001144aef0 in /usr/bin/clickhouse
7. DB::DatabaseLazy::tryGetTable(String const&) const @ 0x0000000011d758ca in /usr/bin/clickhouse
8. DB::DatabaseLazy::tryGetTable(String const&, std::shared_ptr<DB::Context const>) const @ 0x0000000011d7991d in /usr/bin/clickhouse
9. DB::DatabaseCatalog::getTableImpl(DB::StorageID const&, std::shared_ptr<DB::Context const>, std::optional<DB::Exception>*) const @ 0x00000000116e14ab in /usr/bin/clickhouse
10. DB::InterpreterDropQuery::executeToTableImpl(std::shared_ptr<DB::Context const>, DB::ASTDropQuery&, std::shared_ptr<DB::IDatabase>&, StrongTypedef<wide::integer<128ul, unsigned int>, DB::UUIDTag>&) @ 0x0000000011da6ea9 in /usr/bin/clickhouse
11. DB::InterpreterDropQuery::execute() @ 0x0000000011da4030 in /usr/bin/clickhouse
12. DB::executeQueryImpl(char const*, char const*, std::shared_ptr<DB::Context>, bool, DB::QueryProcessingStage::Enum, DB::ReadBuffer*) @ 0x00000000122c3ec8 in /usr/bin/clickhouse
13. DB::executeQuery(String const&, std::shared_ptr<DB::Context>, bool, DB::QueryProcessingStage::Enum) @ 0x00000000122bf635 in /usr/bin/clickhouse
14. DB::TCPHandler::runImpl() @ 0x000000001313b339 in /usr/bin/clickhouse
15. DB::TCPHandler::run() @ 0x000000001314d719 in /usr/bin/clickhouse
16. Poco::Net::TCPServerConnection::start() @ 0x0000000015b465f4 in /usr/bin/clickhouse
17. Poco::Net::TCPServerDispatcher::run() @ 0x0000000015b477f1 in /usr/bin/clickhouse
18. Poco::PooledThread::run() @ 0x0000000015c7e427 in /usr/bin/clickhouse
19. Poco::ThreadImpl::runnableEntry(void*) @ 0x0000000015c7c6fc in /usr/bin/clickhouse
20. start_thread @ 0x00000000000076db in /lib/x86_64-linux-gnu/libpthread-2.27.so
21. ? @ 0x000000000012161f in /lib/x86_64-linux-gnu/libc-2.27.so

Ref:

ClickHouse/src/Common/FileChecker.cpp

Line 115 in 6c0450f

void FileChecker::repair()

Logic for local disk: #12426

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

Modify your CI run

NOTE: If your merge the PR with modified CI you MUST KNOW what you are doing
NOTE: Checked options will be applied if set before CI RunConfig/PrepareRunConfig step

Include tests (required builds will be added automatically):

• Fast test
• Integration Tests
• Stateless tests
• Stateful tests
• Unit tests
• Performance tests
• All with ASAN
• All with TSAN
• All with Analyzer
• All with Azure
• Add your option here

Exclude tests:

• Fast test
• Integration Tests
• Stateless tests
• Stateful tests
• Performance tests
• All with ASAN
• All with TSAN
• All with MSAN
• All with UBSAN
• All with Coverage
• All with Aarch64
• Add your option here

Extra options:

• do not test (only style check)
• disable merge-commit (no merge from master before tests)
• disable CI cache (job reuse)

Only specified batches in multi-batch jobs:

• 1
• 2
• 3
• 4

[robot-ch-test-poll2]

This is an automated comment for commit b43fd17 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check name	Description	Status
A Sync	There's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS	⏳ pending
CI running	A meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR	⏳ pending
Mergeable Check	Checks if all other necessary checks are successful	❌ failure
Performance Comparison	Measure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests	❌ failure

Successful checks

Check name	Description	Status
AST fuzzer	Runs randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help	✅ success
ClickBench	Runs [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table	✅ success
ClickHouse build check	Builds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process	✅ success
Compatibility check	Checks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help	✅ success
Docker keeper image	The check to build and optionally push the mentioned image to docker hub	✅ success
Docker server image	The check to build and optionally push the mentioned image to docker hub	✅ success
Docs check	Builds and tests the documentation	✅ success
Fast test	Normally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here	✅ success
Flaky tests	Checks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc	✅ success
Install packages	Checks that the built packages are installable in a clear environment	✅ success
Integration tests	The integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests	✅ success
PR Check	There's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS	✅ success
Stateful tests	Runs stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc	✅ success
Stateless tests	Runs stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc	✅ success
Stress test	Runs stateless functional tests concurrently from several clients to detect concurrency-related errors	✅ success
Style check	Runs a set of checks to keep the code style clean. If some of tests failed, see the related log from the report	✅ success
Unit tests	Runs the unit tests for different release types	✅ success
Upgrade check	Runs stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts	✅ success

[MikhailBurdukov]

Failed tests looks unrelated for me, @kssenii could you check pls?

[MikhailBurdukov]

@kssenii Merge?