Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial support for loongarch64 #63733

Merged
merged 9 commits into from
May 18, 2024

Conversation

qiangxuhui
Copy link
Contributor

@qiangxuhui qiangxuhui commented May 14, 2024

Changelog category (leave one):

  • Build/Testing/Packaging Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Experimentally support loongarch64 as a new platform for ClickHouse.

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

Modify your CI run

NOTE: If your merge the PR with modified CI you MUST KNOW what you are doing
NOTE: Checked options will be applied if set before CI RunConfig/PrepareRunConfig step

Include tests (required builds will be added automatically):

  • Fast test
  • Integration Tests
  • Stateless tests
  • Stateful tests
  • Unit tests
  • Performance tests
  • All with ASAN
  • All with TSAN
  • All with Analyzer
  • All with Azure
  • Add your option here

Exclude tests:

  • Fast test
  • Integration Tests
  • Stateless tests
  • Stateful tests
  • Performance tests
  • All with ASAN
  • All with TSAN
  • All with MSAN
  • All with UBSAN
  • All with Coverage
  • All with Aarch64
  • Add your option here

Extra options:

  • do not test (only style check)
  • disable merge-commit (no merge from master before tests)
  • disable CI cache (job reuse)

Only specified batches in multi-batch jobs:

  • 1
  • 2
  • 3
  • 4

Make ClickHouse compilable and runnable on loongarch64

So far only basic functionality was tested (on real hw),
clickhouse server runs, exceptions works, client works,
simple tests works.
Fix `base/poco` and `contrib/openssl-cmake` based on code review comments(ClickHouse#61509).
@qiangxuhui qiangxuhui changed the title Qiangxuhui loongarch64 Initial support for loongarch64 May 14, 2024
@qiangxuhui
Copy link
Contributor Author

@alexey-milovidov @rschu1ze Because my branch name for loongarch64 is the same as the upstream branch name for loongarch64, I renamed my branch, but this caused the PR #61509 to be closed. So I re-send this PR.

@rschu1ze rschu1ze self-assigned this May 14, 2024
@rschu1ze rschu1ze mentioned this pull request May 14, 2024
1 task
@rschu1ze rschu1ze added the can be tested Allows running workflows for external contributors label May 14, 2024
@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added pr-feature Pull request with new product feature submodule changed At least one submodule changed in this PR. labels May 14, 2024
@robot-clickhouse-ci-1
Copy link
Contributor

robot-clickhouse-ci-1 commented May 14, 2024

This is an automated comment for commit 5fb8ea4 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check nameDescriptionStatus
A SyncThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS⏳ pending
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help❌ failure
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR⏳ pending
Mergeable CheckChecks if all other necessary checks are successful❌ failure
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors❌ failure
Successful checks
Check nameDescriptionStatus
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
PR CheckThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success

.github/workflows/master.yml Outdated Show resolved Hide resolved
docker/packager/packager Show resolved Hide resolved
src/Common/ThreadFuzzer.cpp Show resolved Hide resolved
cmake/target.cmake Outdated Show resolved Hide resolved
@clickhouse-ci clickhouse-ci bot added manual approve Manual approve required to run CI labels May 14, 2024
@alexey-milovidov

This comment was marked as resolved.

@qiangxuhui

This comment was marked as resolved.

@alexey-milovidov

This comment was marked as resolved.

@qiangxuhui

This comment was marked as resolved.

@rschu1ze
Copy link
Member

I have updated the submodule contrib/libunwind to master, but there are still code conflicts, Do I need to rebase master to resolve the code conflicts?

I just merged from master, that resolves the issue.

@qiangxuhui Let's also avoid force-pushing once the code has been reviewed. A force-push allows to rewrite the entire commit history, meaning that all previously reviewed code (20k LOC in this PR) need to be re-reviewed.

@qiangxuhui
Copy link
Contributor Author

qiangxuhui commented May 17, 2024

I just merged from master, that resolves the issue.

@qiangxuhui Let's also avoid force-pushing once the code has been reviewed. A force-push allows to rewrite the entire commit history, meaning that all previously reviewed code (20k LOC in this PR) need to be re-reviewed.

@rschu1ze Thank you, I will follow your suggestions in future code push. What can I do next?

@rschu1ze
Copy link
Member

rschu1ze commented May 17, 2024

Let's wait for results of CI builds/tests, if green we can merge this PR.

@rschu1ze rschu1ze enabled auto-merge May 17, 2024 14:46
@qiangxuhui
Copy link
Contributor Author

@rschu1ze AST fuzzer (debug) and Stress test (debug) failed, do I need to fix them?

@alexey-milovidov alexey-milovidov merged commit a2d9a32 into ClickHouse:master May 18, 2024
226 of 233 checks passed
@robot-clickhouse robot-clickhouse added the pr-synced-to-cloud The PR is synced to the cloud repo label May 18, 2024
@Algunenano Algunenano added pr-build Pull request with build/testing/packaging improvement and removed pr-feature Pull request with new product feature labels May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
can be tested Allows running workflows for external contributors manual approve Manual approve required to run CI pr-build Pull request with build/testing/packaging improvement pr-synced-to-cloud The PR is synced to the cloud repo submodule changed At least one submodule changed in this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants