-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix insignificant UBSAN error in QueryAnalyzer::replaceNodesWithPositionalArguments() #63734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robot-ch-test-poll1
added
the
pr-not-for-changelog
This PR should not be mentioned in the changelog
label
May 14, 2024
This is an automated comment for commit 710ceae with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page
Successful checks
|
novikd
approved these changes
May 14, 2024
robot-ch-test-poll3
added
the
pr-synced-to-cloud
The PR is synced to the cloud repo
label
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
analyzer
Issues and pull-requests related to new analyzer
fuzz
Problem found by one of the fuzzers
pr-not-for-changelog
This PR should not be mentioned in the changelog
pr-synced-to-cloud
The PR is synced to the cloud repo
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Error: https://s3.amazonaws.com/clickhouse-test-reports/63730/f6cc1051c162029c316d75feecd6efedf3781289/ast_fuzzer__ubsan_/stderr.log
Simplified query:
select 1 group by -9223372036854775808
It actually works correctly ("Negative positional argument number -9223372036854775808 is out of bounds" exception), but UBSAN is not happy.
Avoid
std::abs()
on integers parsed from the query.