Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop gRPC client #1403

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Drop gRPC client #1403

wants to merge 2 commits into from

Conversation

zhicwu
Copy link
Contributor

@zhicwu zhicwu commented Jul 16, 2023 •
edited

Summary

Closes #1399

Checklist

Delete items not relevant to your PR:

  • Unit and integration tests covering the common scenarios were added
  • A human-readable description of the changes was provided to include in CHANGELOG
  • For significant changes, documentation in https://github.com/ClickHouse/clickhouse-docs was updated with further explanations or tutorials

@sonarcloud
Copy link

sonarcloud bot commented Jul 16, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@zhicwu
Copy link
Contributor Author

zhicwu commented Jul 16, 2023

Hi @mzitnik, please review this pull request at your earliest convenience. I will be submitting a few more pull requests for updating dependencies, addressing bugs, and merging pending pull requests.

@zhicwu zhicwu assigned zhicwu and unassigned mzitnik Jul 18, 2023
@zhicwu zhicwu requested a review from mzitnik July 18, 2023 23:10
@zhicwu zhicwu mentioned this pull request Jul 18, 2023
Closed
3 tasks
@mzitnik
Copy link
Contributor

mzitnik commented Jul 19, 2023

@zhicwu did you decide to drop gRPC ?

@zhicwu
Copy link
Contributor Author

zhicwu commented Jul 19, 2023

Yes, I see no benefit of keeping this but troubles(e.g. never production ready, CI failure time from time, and extra dependencies etc.). As I mentioned in the linked issue, Apache Arrow Flight is probably a better choice, and hopefully it will be supported in the future.

@mshustov mshustov added this to the 0.7 release milestone Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mzitnik mzitnik Awaiting requested review from mzitnik

At least 1 approving review is required to merge this pull request.

Assignees

@zhicwu zhicwu

Labels
None yet
Projects
None yet
Milestone
0.7 release
Development

Successfully merging this pull request may close these issues.

Drop clickhouse-grpc-client
3 participants
@zhicwu @mzitnik @mshustov