Get ResultSet meta data before execution #1434
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebyhr
reviewed
Aug 29, 2023
| public void testGetMetaData() throws SQLException { | ||
| try (Connection conn = newConnection(new Properties()); | ||
| PreparedStatement ps = conn.prepareStatement("select ? a, ? b")) { | ||
| ResultSetMetaData md = ps.getMetaData(); |
There was a problem hiding this comment.
What happens if we pass DDL (e.g. CREATE TABLE) to conn.prepareStatement? It would be nice to add a test in my opinion.
There was a problem hiding this comment.
Thanks for taking your time to review the PR!
What happens if we pass DDL (e.g. CREATE TABLE) to conn.prepareStatement?
null will be returned at this point. Below is the check in SqlBasedPreparedStatement.java. However, in ClickHouse, create table on cluster will actually return ResultSet, but I guess we don't need that as it's not helping for push-down implementation.
if (parsedStmt.isRecognized() && !parsedStmt.isQuery()) {
return null;
}It would be nice to add a test in my opinion.
Yes, the implementation is incomplete and I'll add more tests for sure.
|
Hi, any plans to complete this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Get ResultSet meta data before execution
Checklist
Delete items not relevant to your PR: