Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DateTime64 range for clickhouse #1103 #1441

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

yatendra-iratech
Copy link

@yatendra-iratech yatendra-iratech commented Sep 6, 2023

Summary

Fix for issue #1103.

Checklist

Delete items not relevant to your PR:

  • Unit and integration tests covering the common scenarios were updated

Signed-off-by: Yatendra Singh <yatendra.singh@iratechnologies.com>
@CLAassistant
Copy link

CLAassistant commented Sep 6, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@zhicwu zhicwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @yatendra-iratech, thanks for the pull request. select toDateTime64('2299-12-31 23:59:59.999999999', 9) ends up with error Code: 407. DB::Exception: Decimal math overflow: While processing toDateTime64('2299-12-31 23:59:59.999999999', 9). (DECIMAL_OVERFLOW).

Could you update the PR according to https://clickhouse.com/docs/en/sql-reference/data-types/datetime64?

Supported range of values: [1900-01-01 00:00:00, 2299-12-31 23:59:59.99999999]

Note: The precision of the maximum value is 8. If the maximum precision of 9 digits (nanoseconds) is used, the maximum supported value is 2262-04-11 23:47:16 in UTC.

TimonSP added a commit to TimonSP/clickhouse-java that referenced this pull request Jan 9, 2024
mzitnik pushed a commit that referenced this pull request Jan 11, 2024
…limits check layer (#1518)

* Update Date32 and DateTime64 range for ClickHouse, remove datetime64 limits check layer #1103 #1386 #1441

* fix of byte arrays for updated dates in BinaryStreamUtilsTest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants