Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DoubleValue update of inf str #1483

Merged
merged 2 commits into from
May 30, 2024
Merged

Conversation

Chen768959
Copy link
Contributor

@Chen768959 Chen768959 commented Nov 9, 2023

Summary

When SQL is formatted using the FORMAT TabSeparatedWithNamesAndTypes in ClickHouse
the ClickHouseTabSeparatedProcessor will update the value as a String. In this case, if the double type is inf, -inf, or nan, it will not be able to be parsed.

for example
image

Checklist

Delete items not relevant to your PR:

  • Unit and integration tests covering the common scenarios were added
  • A human-readable description of the changes was provided to include in CHANGELOG
  • For significant changes, documentation in https://github.com/ClickHouse/clickhouse-docs was updated with further explanations or tutorials

@mzitnik
Copy link
Contributor

mzitnik commented Nov 28, 2023

@Chen768959 sorry for the delay
Can you some tests to cover

@mzitnik mzitnik self-requested a review November 28, 2023 12:58
@Chen768959
Copy link
Contributor Author

@Chen768959 sorry for the delay Can you some tests to cover
Sure

@chernser chernser self-requested a review May 30, 2024 18:43
@chernser chernser merged commit 5c8f5b0 into ClickHouse:main May 30, 2024
57 of 58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants