fix response close for getRowsUpdated(#1538) #1539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
chernser
approved these changes
May 30, 2024
|
@wooEnrico would you please resubmit your PR? I have accidently merge it but it broke com.clickhouse.r2dbc.spi.test.R2DBCTestKitImplTest.segmentSelectWithEmitsRow what is part of 3rd-party test library. Please also put more description about why this change is needed and what is the problem with current code. Thanks! |
|
I have improved the submission and passed the unit test. And I hope you can review #1667 again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Mono resource manager for updateCount close the response when complete
Checklist
Delete items not relevant to your PR: