Adding cloud tests #1575
Adding cloud tests #1575
Conversation
|
mzitnik seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
| @@ -134,7 +137,8 @@ public void testIssue1373() throws SQLException { | |||
| String sql = String.format("INSERT INTO %s (%s) SELECT %s FROM input %s", TABLE_NAME, columnNames, columnNames, columnValues); | |||
| Connection conn = dataSource.getConnection("default", ""); | |||
| Statement st = conn.createStatement(); | |||
| st.execute(String.format("CREATE TABLE %s (`event_id` String, `num01` Int8, `event_id_01` String) ENGINE = Log", TABLE_NAME)); | |||
| st.execute(String.format("DROP TABLE IF EXISTS %s", TABLE_NAME)); | |||
There was a problem hiding this comment.
I think it will become a problem for concurrent builds because tests will use shared DB and table names for each test run are not unique.
Adding timestamp to the table might solve the issue, but it requires extra steps for tables cleanup (if tests were aborted)
There was a problem hiding this comment.
Agree, but as you can see it still in draft
There was a problem hiding this comment.
Right. I've commented just to have a discussion about it.
There was a problem hiding this comment.
js client uses the same technic as @chernser proposed https://github.com/ClickHouse/clickhouse-js/blob/abb35e9c76377a2a688bb2e4705df13749143b71/packages/client-common/__tests__/utils/client.ts#L89
go client just creates a new instance using terraform https://github.com/ClickHouse/clickhouse-go/blob/b576bdef50952f0f6b8a26e5e6f641ca549b71f1/.github/workflows/run-tests-cloud.yml
|
Summary
Adding cloud tests coverage
Checklist
Delete items not relevant to your PR: