Drain the response stream in the command method #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slvrtrn
commented
May 7, 2024
| if (!params.body) return request.end() | ||
| }) | ||
| } | ||
|
|
There was a problem hiding this comment.
The buildDefaultHeaders/createClientRequest/request methods were moved to the bottom cause it was too annoying to have it at the very top (no other changes).
slvrtrn
commented
May 7, 2024
| } finally { | ||
| controllerCleanup() | ||
| } | ||
| } |
There was a problem hiding this comment.
This one was used for both exec + command client methods. Now, the connection has them separate, but the logic is still (mostly) shared.
slvrtrn
commented
May 7, 2024
| @@ -18,5 +18,4 @@ export const WebImpl: ImplementationDetails<ReadableStream>['impl'] = { | |||
| query_id: string, | |||
| ) => new ResultSet(stream, format, query_id)) as any, | |||
| values_encoder: new WebValuesEncoder(), | |||
| close_stream: (stream) => stream.cancel(), | |||
There was a problem hiding this comment.
Finally, we don't need this anymore.
|
mshustov
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
commandmethod now drains the response stream properly, as the previous implementation could cause the Keep-Alive socket to close after each request.Checklist