Feature/ensembl endpoints and db model #7
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Jan 20, 2022
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
src/schug/endpoints/ensembl.py
Outdated
| return ensembl_genes | ||
|
|
||
|
|
||
| @router.get("/{ensembl_gene_id}", response_model=List[EnsemblTranscriptRead]) |
There was a problem hiding this comment.
Suggested change
| @router.get("/{ensembl_gene_id}", response_model=List[EnsemblTranscriptRead]) | |
| @router.get("/{ensembl_gene_id}", response_model=List[EnsemblTranscript]) |
Right? How it was produced is not important to the caller
|
note to self: https://developer.mozilla.org/en-US/docs/Web/HTTP/Status/204 use this status code because 404 (https://developer.mozilla.org/en-US/docs/Web/HTTP/Status/404) means client requested resource doesn't exist when it does EDIT: seems more difficult than I thought because and the return of my endpoints do have a body if wrong client input i.e. empty array Taking Henrik's http class from atlas |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds | fixes:
How to prepare for test:
sshto ...bash servers/resources/SERVER.scilifelab.se/update-[THIS_TOOL]-stage.sh [THIS-BRANCH-NAME]How to test:
Expected outcome:
Review:
This version is a: