Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix URL to GRCh37 Biomart #68

Closed
wants to merge 3 commits into from
Closed

Conversation

northwestwitch
Copy link
Member

This PR adds | fixes:

How to prepare for test:

  • ssh to ...
  • Install on stage:
    bash servers/resources/SERVER.scilifelab.se/update-[THIS_TOOL]-stage.sh [THIS-BRANCH-NAME]

How to test:

Expected outcome:

  • [ ]

Review:

  • Code approved by
  • Tests executed by
  • "Merge and deploy" approved by

This version is a:

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

Copy link

sonarcloud bot commented Mar 21, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@@ -4,7 +4,7 @@
import requests

LOG = logging.getLogger(__name__)
BIOMART_37_URL = "https://feb2014.archive.ensembl.org/biomart/martservice?query="
BIOMART_37_URL = "https://grch37.ensembl.org/biomart/martservice?query="
BIOMART_38_URL = "https://www.ensembl.org/biomart/martservice?query="
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be the same data, right?

image

@northwestwitch
Copy link
Member Author

northwestwitch commented Mar 21, 2024

This is a folder with Schug downloads from the beginning of February:

image

This the the genes file downloaded today with this branch:

image

They're different files!

@northwestwitch
Copy link
Member Author

This is a folder from hasta with the Ensembl files I used for updating genes in Scout last time. The same size of the genes files downloaded genes file when the old archive worked.

image

@northwestwitch
Copy link
Member Author

I have now sent an email to the Ensembl helpdesk asking why we see these differences in number of genes downloaded using supposedly the same archive. I think I'll leave this suspended until I get a reply.

@northwestwitch
Copy link
Member Author

They did some testing and finally put back online the old Ensembl archive v.75, which seems to be working fine now, so I'm closing this PR and the relative issues in the repo and the ones that use schug as dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GRCh37 Resources are not downloaded from Ensembl
1 participant