Add dark mode support to context menu #355
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
your patch is perfect, but it can only work in primary monitor, when my mouse placed in the second monitor, I can not trigger the context menu. @MartinPham |
|
@MartinPham Thanks for the PR. Also, I'm sorry I haven't been able to respond for a long time. As a result of building with the current develop branch and Xcode12.2/macOS 10.15 Catalina, the menu seems to have dark mode support without changing the code.
Does this work-around still seem necessary? |
|
@Econa77 if dark mode is supported directly in OS as you said, it would be great to create a new Clippy release |
|
Here is a zip file of clipy.app build on newer mac. clipy now which supports dark mode |
yldrmzffr
approved these changes
Mar 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #306