This repository has been archived by the owner on Jul 5, 2021. It is now read-only.
chore(deps): update dependency eslint-config-prettier to v8 #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![renovate[bot]](https://avatars.githubusercontent.com/in/2740?s=60&v=4){kind=small}
renovate
bot
force-pushed
the
renovate/eslint-config-prettier-8.x
branch
from
8ff3dd8
to
087e782
Compare
renovate
bot
force-pushed
the
renovate/eslint-config-prettier-8.x
branch
from
087e782
to
68563cb
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
3.6.0->8.3.0Release Notes
prettier/eslint-config-prettier
v8.3.0Compare Source
v8.2.0Compare Source
v8.1.0Compare Source
v8.0.0Compare Source
Changed: All configs have been merged into one!
To upgrade, change:
{ "extends": [ "some-other-config-you-use", "prettier", "prettier/@​typescript-eslint", "prettier/babel", "prettier/flowtype", "prettier/react", "prettier/standard", "prettier/unicorn", "prettier/vue" ] }Into:
{ "extends": [ "some-other-config-you-use", "prettier" ] }The
"prettier"config now includes not just ESLint core rules, but also rules from all plugins. Much simpler!So … what’s the catch? Why haven’t we done this earlier? Turns out it’s just a sad mistake. I (@lydell) was confused when testing, and thought that turning off unknown rules in a config was an error. Thanks to Georgii Dolzhykov (@thorn0) for pointing this out!
If you use [eslint-plugin-prettier], all you need is [plugin:prettier/recommended]:
{ "extends": [ "some-other-config-you-use", "plugin:prettier/recommended" ] }(The ["prettier/prettier" config][prettier-prettier-config] still exists separately. It’s the odd one out. The main
"prettier"config does not include the rules from it.)Changed: The CLI helper tool now only prints warnings for [arrow-body-style] and [prefer-arrow-callback], just like other “special rules.” This means that if you’ve decided to use those rules and [eslint-plugin-prettier] at the same time, you’ll get warnings but exit code zero (success).
v7.2.0Compare Source
v7.1.0Compare Source
v7.0.0Compare Source
Changed: At least ESLint 7.0.0 is now required.
Changed: [arrow-body-style] and [prefer-arrow-callback] are no longer turned off by default. They only need to be turned off if you use [eslint-plugin-prettier]. If you do, add
"prettier/prettier"to your"extends"array to turn them off again.{ "extends": ["prettier", "prettier/prettier"], "plugins": ["prettier"], "rules": { "prettier/prettier": "error" } }Alternatively, update [eslint-plugin-prettier] to version 3.2.0 or later which automatically turns off these two rules in its
"plugin:prettier/recommended"config.The CLI helper tool only warns about these rules if you have the
"prettier/prettier"rule enabled for a file.Changed:
no-tabsis now a validatable rule. If you use it, you should enableallowIndentationTabsso that the rule works regardless of your Prettier config:{ "rules": { "no-tabs": ["error", { "allowIndentationTabs": true }] } }Changed: The CLI helper tool is now called just
eslint-config-prettierinstead ofeslint-config-prettier-check. This is so thatnpx eslint-config-prettieralways works regardless of whether you have already installedeslint-config-prettieror not: If you have, the local installation is used; if you haven’t,npxdownloads a temporary copy.Changed: The CLI helper tool no longer requires you to pipe the output of
eslint --print-configto it. Instead, it does that automatically for you via ESLint API:s added in ESLint v7.Before:
After:
Improved: The npm package is now 75% smaller.
v6.15.0Compare Source
v6.14.0Compare Source
v6.13.0Compare Source
v6.12.0Compare Source
v6.11.0Compare Source
v6.10.1Compare Source
npxwhen running the CLI helper tool.v6.10.0Compare Source
v6.9.0Compare Source
v6.8.0Compare Source
v6.7.0Compare Source
v6.6.0Compare Source
v6.5.0Compare Source
v6.4.0Compare Source
v6.3.0Compare Source
v6.2.0Compare Source
v6.1.0Compare Source
v6.0.0Compare Source
Changed: The CLI helper tool now considers [no-confusing-arrow] to conflict if you use the default value of its
allowParensoption. The default was changed totruein ESLint 6, which conflicts with Prettier.If the CLI helper tool gives you errors about this after upgrading, the solution is to change this:
{ "rules": { "no-confusing-arrow": ["error"] } }Into this:
{ "rules": { "no-confusing-arrow": ["error", { "allowParens": false }] } }The latter works in both ESLint 6 as well as in ESLint 5 and older.
Improved:
eslint --print-configusage instructions. The CLI tool help text as well as the documentation has been updated to suggest commands that work in ESLint 6.0 as well as in ESLint 5 and older. (Instead ofeslint --print-config ., useeslint --print-config path/to/main.js.)v5.1.0Compare Source
v5.0.0Compare Source
Removed: [react/self-closing-comp]. This rule was added in v4.1.0 not because it conflicted with Prettier but because it was unnecessary when using Prettier. However, in v1.18.0 [Prettier stopped converting empty elements to self-closing elements][prettier-self-closing]. So the rule is not unnecessary anymore.
If you use Prettier v1.17.1 or older you should be able to upgrade eslint-config-prettier to v5.0.0 without having to do anything else.
If you use Prettier v1.18.0 or newer, you might get lint errors about for example changing
<div></div>into<div />. You have two options:eslint --fixif you prefer to enforce self-closing elements where possible. This should fix all the errors."react/self-closing-comp": "off"to your ESLint config if you use autofix from your editor and you face the same [issue as Prettier did][prettier-self-closing].Changed: Node.js 6 is no longer officially supported, but v5.0.0 should still work with it.
v4.3.0Compare Source
v4.2.0Compare Source
v4.1.0Compare Source
v4.0.0Compare Source
--fix. They are turned off by default, and the CLI helper tool will warn about them (but not error if you do enable them). This won’t break your linting checks, but do note that these rules will be disabled unless you explicitly enable them again, and that you might see new warnings when running the CLI helper tool.Configuration
📅 Schedule: At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻️ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by WhiteSource Renovate. View repository job log here.