Skip to content
This repository has been archived by the owner on May 5, 2022. It is now read-only.

add method which allows adding custom metrics #17

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

amitmtrn
Copy link

I've added method which allows adding custom metrics.
I tried to keep the code style although I had to make the options globally available in order to use the same appmetrics instance in addMetric method.

@codecov-io
Copy link

codecov-io commented Apr 30, 2018

Codecov Report

Merging #17 into master will decrease coverage by 4.61%.
The diff coverage is 40%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #17      +/-   ##
==========================================
- Coverage   91.08%   86.47%   -4.62%     
==========================================
  Files           2        2              
  Lines         157      170      +13     
==========================================
+ Hits          143      147       +4     
- Misses         14       23       +9
Impacted Files Coverage Δ
lib/appmetrics-prometheus.js 86.39% <40%> (-4.64%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a8bdf1...92d6dbe. Read the comment docs.

@CLAassistant
Copy link

CLAassistant commented Jul 31, 2018

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants